Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v2.8] OOB Chart Release for longhorn and rancher-istio #3612

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

lucasmlp
Copy link
Contributor

@lucasmlp lucasmlp commented Mar 13, 2024

Issues:

longhorn 103.2.2+up1.5.4

rancher-istio 103.1.0+up1.19.6

Pull-Requests:

longhorn 103.2.2+up1.5.4

rancher-istio 103.1.0+up1.19.6

Charts Checklist (built for v0.5.2 charts-build-scripts)

Checkpoint 0: Validate release.yaml

Validation steps:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

  • Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

@rancher rancher deleted a comment from github-actions bot Mar 13, 2024
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@rancher rancher deleted a comment from github-actions bot Mar 13, 2024
@lucasmlp lucasmlp marked this pull request as ready for review March 13, 2024 15:03
@lucasmlp lucasmlp requested a review from a team March 13, 2024 15:05
Copy link
Collaborator

@nicholasSUSE nicholasSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the title

@lucasmlp lucasmlp changed the title [release-v2.8] OOB Chart Release for longhorn 103.2.2+up1.5.4 [release-v2.8] OOB Chart Release for longhorn and rancher-istio Mar 13, 2024
@lucasmlp lucasmlp merged commit 55a78da into release-v2.8 Mar 13, 2024
7 checks passed
@lucasmlp lucasmlp deleted the oob-march-13/release-v2.8 branch March 13, 2024 19:48
@lucasmlp lucasmlp restored the oob-march-13/release-v2.8 branch March 13, 2024 19:49
@lucasmlp lucasmlp added the regsync-ready PR ready to sync images with prime registry label Mar 13, 2024
lucasmlp added a commit that referenced this pull request Mar 13, 2024
@lucasmlp lucasmlp added regsync-ready PR ready to sync images with prime registry and removed regsync-ready PR ready to sync images with prime registry labels Mar 13, 2024
@lucasmlp lucasmlp deleted the oob-march-13/release-v2.8 branch March 14, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regsync-ready PR ready to sync images with prime registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants