Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v2.8] Second chart batch release for Rancher v2.8.3 #3687

Merged
merged 12 commits into from
Mar 25, 2024

Conversation

lucasmlp
Copy link
Contributor

@lucasmlp lucasmlp commented Mar 21, 2024

Charts:

elemental 103.1.0+up1.4.2:

rancher-backup 103.0.1+up4.0.1:

rancher-webhook 103.0.2+up0.4.3:

system-upgrade-controller 103.0.1+up0.6.0:

Charts Checklist (built for v5.2.x charts-build-scripts)

Checkpoint 0: Validate release.yaml

Validation steps:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

  • Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

  • The index.yaml file has an entry for each chart version.
  • The index.yaml entries for each chart matches the Chart.yaml for each chart.
  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

lucasmlp and others added 2 commits March 21, 2024 19:21
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
@lucasmlp lucasmlp changed the base branch from dev-v2.9 to release-v2.8 March 21, 2024 22:24
@lucasmlp lucasmlp changed the title V2.8.3/batch 2 [release-v2.8] Second chart batch release for Rancher v2.8.3 Mar 21, 2024
@rancher rancher deleted a comment from github-actions bot Mar 21, 2024
@rancher rancher deleted a comment from github-actions bot Mar 21, 2024
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@rancher rancher deleted a comment from github-actions bot Mar 21, 2024
@lucasmlp lucasmlp marked this pull request as ready for review March 21, 2024 22:57
@lucasmlp lucasmlp requested a review from a team March 22, 2024 09:33
@lucasmlp lucasmlp added the regsync-ready PR ready to sync images with prime registry label Mar 25, 2024
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@lucasmlp lucasmlp merged commit 0223595 into release-v2.8 Mar 25, 2024
5 checks passed
@lucasmlp lucasmlp deleted the v2.8.3/batch-2 branch March 25, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regsync-ready PR ready to sync images with prime registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants