[dev-v2.7] longhorn 102.4.0+up1.6.1 add #3753

mantissahz · 2024-04-08T13:32:11Z

Release Longhorn v1.6.1 into Rancher 2.7

Longhorn longhorn/longhorn#8209
Rancher rancher/rancher#44861

Signed-off-by: James Lu james.lu@suse.com

cc @innobead @PhanLe1010 @khushboo-rancher @roger-ryao

Waiting for Longhorn 1.6.1 images merged into the Rancher image-mirror list.

github-actions · 2024-04-08T13:32:22Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

nicholasSUSE

Hello, we have improved the Charts documentation regarding Pull Request Rules.

Please take a look at it before making any new Pull Requests.
We are still approving Pull Requests and starting to inform all teams, soon we will require the standard in the documentation.

https://github.com/rancher/charts?tab=readme-ov-file#pull-request-rules

packages/longhorn-crd/longhorn-1.6/package.yaml

packages/longhorn/longhorn-1.6/package.yaml

packages/longhorn/longhorn-1.6/generated-changes/overlay/templates/validate-install-crd.yaml

packages/longhorn/longhorn-1.6/generated-changes/overlay/templates/userroles.yaml

charts/longhorn/102.4.1+up1.6.1/templates/validate-install-crd.yaml

charts/longhorn/102.4.1+up1.6.1/templates/userroles.yaml

github-actions · 2024-04-09T02:40:57Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-04-09T02:44:37Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

github-actions · 2024-04-09T03:13:42Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

roger-ryao · 2024-04-09T10:24:04Z

Prerequisites:

Set the Concurrent Automatic Engine Upgrade Per Node Limit to a value greater than 0.
LONGHORN_REPO is set to longhornio.
Rancher : v2.7.12

Verify is passed as follows step

Fresh installation
Uninstallation
Upgrade from 102.3.2+up1.5.4 - > 102.4.0+up1.6.1

PhanLe1010

LGTM

PhanLe1010 · 2024-04-09T20:32:20Z

Cannot merge because the image validation script failed with error:

time="2024-04-09T20:08:58Z" level=fatal msg="failed to generate namespace and repository for image: quay.io/openshift/origin-oauth-proxy"
make: *** [Makefile:17: check-images] Error 1
Error: Process completed with exit code 2.

It is is failed at this line of code https://github.com/rancher/charts-build-scripts/blob/a7001e331fda7b61c8df358862f46436eaae9df2/pkg/images/checkImages.go#L55-L59. It means that the recent added image in Longhorn, quay.io/openshift/origin-oauth-proxy, doesn't follow the format <repo>/<image-name>.

I think even if we solve the image format, the script will still failed because quay.io/openshift/origin-oauth-proxy is not mirrored to Longhorn repo and to Rancher repo yet. We should mirror them similar to what we did for CSI component.

Creating a new GitHub ticket: longhorn/longhorn#8329

PhanLe1010 · 2024-04-10T19:09:18Z

Waiting for the image PR (adding missing image) rancher/image-mirror#608

github-actions · 2024-04-12T02:05:01Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

PhanLe1010 · 2024-04-12T20:26:25Z

charts/longhorn/102.4.0+up1.6.1/values.yaml

+  openshift:
+    oauthProxy:
+      # -- Repository for the OAuth Proxy image. This setting applies only to OpenShift users.
+      repository: rancher/mirrored-longhornio-openshift-origin-oauth-proxy


Hi @mantissahz we need to add this mirror image to questions.yaml too. Could you help to update the PR?

Added. Thanks

release Longhorn v1.6.1 into Rancher 2.7 Longhorn 8209 Rancher 44861 Signed-off-by: James Lu <james.lu@suse.com>

github-actions · 2024-04-15T02:39:02Z

Validation steps

Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913

Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
Approve the PR to run the CI check.

PhanLe1010

LGTM

PhanLe1010 · 2024-04-15T18:44:27Z

@khushboo-rancher Because we have had significant modifications since the last test run, could we retest the PR? Once it pass, I will merge the PR

khushboo-rancher · 2024-04-15T20:06:10Z

QA - PASS

Validated below scenarios:

Installation
uninstallation
upgrade
P0 test cases - mounting volume (RWO, RWX), replica rebuilding, backing image etc

Signed-off-by: James Lu <james.lu@suse.com>

mantissahz requested review from PhanLe1010, khushboo-rancher and roger-ryao April 8, 2024 13:32

mantissahz self-assigned this Apr 8, 2024

mantissahz requested review from a team as code owners April 8, 2024 13:32

nicholasSUSE approved these changes Apr 8, 2024

View reviewed changes

PhanLe1010 reviewed Apr 9, 2024

View reviewed changes

PhanLe1010 mentioned this pull request Apr 9, 2024

[dev-v2.8] longhorn 103.3.0+up1.6.1 add #3754

Merged

mantissahz force-pushed the dev-v2.7-lh-1.6.1 branch from 3e8d130 to acd463a Compare April 9, 2024 02:40

mantissahz force-pushed the dev-v2.7-lh-1.6.1 branch from acd463a to b5dbbbb Compare April 9, 2024 02:44

mantissahz force-pushed the dev-v2.7-lh-1.6.1 branch from b5dbbbb to dfe09a0 Compare April 9, 2024 03:13

mantissahz changed the title ~~[dev-v2.7] Add Longhorn 1.6.1 chart~~ [dev-v2.7] longhorn 102.4.0+up1.6.1 add Apr 9, 2024

PhanLe1010 approved these changes Apr 9, 2024

View reviewed changes

PhanLe1010 mentioned this pull request Apr 9, 2024

[TASK] Mirror the quay.io/openshift/origin-oauth-proxy image to Longhorn repo similar to what we are doing for CSI sidecar images longhorn/longhorn#8329

Closed

derekbit mentioned this pull request Apr 10, 2024

Mirror the quay.io/openshift/origin-oauth-proxy image to Longhorn repo and update the chart longhorn/longhorn#8330

Merged

PhanLe1010 mentioned this pull request Apr 10, 2024

Update missing image for Longhorn 1.6.1 Rancher chart release rancher/image-mirror#608

Merged

10 tasks

mantissahz force-pushed the dev-v2.7-lh-1.6.1 branch from dfe09a0 to c64dc12 Compare April 12, 2024 02:04

PhanLe1010 requested changes Apr 12, 2024

View reviewed changes

mantissahz added 2 commits April 15, 2024 10:34

make prepare/patch

eb7885c

release Longhorn v1.6.1 into Rancher 2.7 Longhorn 8209 Rancher 44861 Signed-off-by: James Lu <james.lu@suse.com>

make charts

51292b1

release Longhorn v1.6.1 into Rancher 2.7 Longhorn 8209 Rancher 44861 Signed-off-by: James Lu <james.lu@suse.com>

mantissahz force-pushed the dev-v2.7-lh-1.6.1 branch from c64dc12 to 51292b1 Compare April 15, 2024 02:38

mantissahz requested a review from PhanLe1010 April 15, 2024 02:53

PhanLe1010 approved these changes Apr 15, 2024

View reviewed changes

PhanLe1010 merged commit 77dcbd6 into rancher:dev-v2.7 Apr 15, 2024
6 of 7 checks passed

lucasmlp pushed a commit that referenced this pull request Apr 17, 2024

[dev-v2.7] longhorn 102.4.0+up1.6.1 add (#3753)

080d263

Signed-off-by: James Lu <james.lu@suse.com>

This was referenced Apr 17, 2024

[release-v2.8] OOB release for rancher-sriov #3706

Merged

[release-v2.7] OOB Chart Release for longhorn v1.6.1, neuvector v5.3.2 and neuvector-monitor v5.3.2 #3792

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dev-v2.7] longhorn 102.4.0+up1.6.1 add #3753

[dev-v2.7] longhorn 102.4.0+up1.6.1 add #3753

mantissahz commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

nicholasSUSE left a comment

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 9, 2024

roger-ryao commented Apr 9, 2024

PhanLe1010 left a comment

PhanLe1010 commented Apr 9, 2024 •

edited

Loading

PhanLe1010 commented Apr 10, 2024

github-actions bot commented Apr 12, 2024

PhanLe1010 Apr 12, 2024

mantissahz Apr 15, 2024

github-actions bot commented Apr 15, 2024

PhanLe1010 left a comment

PhanLe1010 commented Apr 15, 2024

khushboo-rancher commented Apr 15, 2024

[dev-v2.7] longhorn 102.4.0+up1.6.1 add #3753

[dev-v2.7] longhorn 102.4.0+up1.6.1 add #3753

Conversation

mantissahz commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

Validation steps

nicholasSUSE left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 9, 2024

Validation steps

github-actions bot commented Apr 9, 2024

Validation steps

github-actions bot commented Apr 9, 2024

Validation steps

roger-ryao commented Apr 9, 2024

PhanLe1010 left a comment

Choose a reason for hiding this comment

PhanLe1010 commented Apr 9, 2024 • edited Loading

PhanLe1010 commented Apr 10, 2024

github-actions bot commented Apr 12, 2024

Validation steps

PhanLe1010 Apr 12, 2024

Choose a reason for hiding this comment

mantissahz Apr 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Apr 15, 2024

Validation steps

PhanLe1010 left a comment

Choose a reason for hiding this comment

PhanLe1010 commented Apr 15, 2024

khushboo-rancher commented Apr 15, 2024

PhanLe1010 commented Apr 9, 2024 •

edited

Loading