-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.8] rancher-logging 103.1.0+up4.4.0 update #3787
[dev-v2.8] rancher-logging 103.1.0+up4.4.0 update #3787
Conversation
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
d438862
to
db32b53
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
db32b53
to
6b33385
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix the merge conflicts, otherwise LGTM
6b33385
to
adb8f9c
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
adb8f9c
to
f44a07e
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
regsync.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be changed by contributors. We have a GitHub action that automatically detects new docker images and updates regsync.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the changes to regsync.yaml
.
f44a07e
to
36f012d
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Issue: rancher/windows#222
Problem
Various components of Rancher are using Windows images which contain Foreign Layer references. This makes mirroring these images more difficult and is a common source of user confusion when configuring windows nodes in air-gapped environments. Other PRs to rancher/rancher and rancher-monitoring have already resulted in many of these images being fixed, however logging has not yet been addressed.
Solution
v1.8.10
v1.8.10
is simply a rebuilt version of1.8.9
which no longer contains foreign layer references. There is no functional difference between the two.rancher-logging 103.1.0-rc1+up4.4.0
rancher-logging 103.1.0-rc2+up4.4.0
Testing
I've confirmed the chart can be installed and works as expected. I've confirmed that
v1.8.10
of rancher/fluent-bit does not include any foreign layer references.Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations
Backporting considerations