-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.7] rancher-logging 102.0.3-rc1+up3.17.10 update #3799
[dev-v2.7] rancher-logging 102.0.3-rc1+up3.17.10 update #3799
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
b5607b2
to
86aa8bc
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make changes to only one main chart per PR. Otherwise, if things goes south and we need to revert this PR, it becomes quite tricky.
regsync.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be changed by contributors. We have a GitHub action that automatically detects new docker images and updates regsync.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, good to know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the changes to regsync.yaml
and taken out the monitoring chart changes, this PR is now only focused on the logging chart changes
86aa8bc
to
be5c838
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Issue: rancher/windows#222
Problem
Various components of Rancher are using Windows images which contain Foreign Layer references. This makes mirroring these images more difficult and is a common source of user confusion when configuring windows nodes in air-gapped environments. Other PRs to rancher/rancher and rancher-monitoring have already resulted in many of these images being fixed, however logging has not yet been addressed.
Solution
v1.8.10
v1.8.10
is simply a rebuilt version of1.8.9
which no longer contains foreign layer references. There is no functional difference between the two.Testing
I've confirmed the chart can be installed and work as expected. I've confirmed the image does not contain foreign layers.
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations
Backporting considerations