Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.8] rancher-vsphere-csi add 103.1.1+up3.1.2-rancher4 #3804

Conversation

HarrisonWAffel
Copy link
Contributor

Issue: rancher/rancher#45093

Problem

The vSphere CSI chart has updated the default value of csiAuthCheck

Solution

Bump the commit used in the vSphere CSI chart to introduce the updated default value

Testing

Testing has been done in the scope of rancher/rancher#45093 and the default value change has been verified to work as a part of the rke2 embedded chart tesitng

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@HarrisonWAffel HarrisonWAffel requested review from a team as code owners April 18, 2024 17:19

This comment was marked as outdated.

@HarrisonWAffel HarrisonWAffel force-pushed the 2.8-bump-vsphere-chart-with-new-defaults branch from c7a2c93 to 17b5d44 Compare April 18, 2024 17:36

This comment was marked as outdated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file not exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@HarrisonWAffel HarrisonWAffel force-pushed the 2.8-bump-vsphere-chart-with-new-defaults branch from 17b5d44 to 1c45d8f Compare April 18, 2024 18:17

This comment was marked as outdated.

@HarrisonWAffel HarrisonWAffel force-pushed the 2.8-bump-vsphere-chart-with-new-defaults branch from 1c45d8f to 5252292 Compare April 18, 2024 19:10
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@lucasmlp lucasmlp changed the title [v2.8] bump vSphere CSI chart to update defaults [dev-v2.8] rancher-vsphere-csi add bump vSphere CSI chart to update defaults Apr 18, 2024
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lucasmlp lucasmlp changed the title [dev-v2.8] rancher-vsphere-csi add bump vSphere CSI chart to update defaults [dev-v2.8] rancher-vsphere-csi add 103.1.1+up3.1.2-rancher4 Apr 18, 2024
@HarrisonWAffel HarrisonWAffel dismissed jiaqiluo’s stale review April 18, 2024 20:02

Change addressed, approved by another member of hostbusters

@HarrisonWAffel HarrisonWAffel merged commit e840204 into rancher:dev-v2.8 Apr 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants