-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.9] rancher-vsphere-csi add 104.0.0+up3.1.2-rancher4 #3806
Merged
HarrisonWAffel
merged 3 commits into
rancher:dev-v2.9
from
HarrisonWAffel:2.9-bump-vsphere-chart-with-new-defaults
Apr 18, 2024
Merged
[dev-v2.9] rancher-vsphere-csi add 104.0.0+up3.1.2-rancher4 #3806
HarrisonWAffel
merged 3 commits into
rancher:dev-v2.9
from
HarrisonWAffel:2.9-bump-vsphere-chart-with-new-defaults
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
HarrisonWAffel
force-pushed
the
2.9-bump-vsphere-chart-with-new-defaults
branch
from
April 18, 2024 17:33
f5ffa51
to
704be22
Compare
This comment was marked as outdated.
This comment was marked as outdated.
HarrisonWAffel
force-pushed
the
2.9-bump-vsphere-chart-with-new-defaults
branch
from
April 18, 2024 18:17
704be22
to
dfb4d2d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
HarrisonWAffel
force-pushed
the
2.9-bump-vsphere-chart-with-new-defaults
branch
from
April 18, 2024 18:40
dfb4d2d
to
ffa5a87
Compare
This comment was marked as outdated.
This comment was marked as outdated.
HarrisonWAffel
force-pushed
the
2.9-bump-vsphere-chart-with-new-defaults
branch
from
April 18, 2024 19:19
ffa5a87
to
a9e2d3d
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
snasovich
approved these changes
Apr 18, 2024
lucasmlp
changed the title
[v2.9] bump vSphere CSI chart to update defaults
[dev-v2.9] rancher-vsphere-csi add 104.0.0+up3.1.2-rancher4
Apr 18, 2024
lucasmlp
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
krunalhinguu
pushed a commit
to krunalhinguu/charts
that referenced
this pull request
May 14, 2024
krunalhinguu
pushed a commit
to krunalhinguu/charts
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#45093
Problem
The vSphere CSI chart has updated the default value of
csiAuthCheck
Solution
Bump the commit used in the vSphere CSI chart to introduce the updated default value
Testing
Testing has been done in the scope of rancher/rancher#45093 and the default value change has been verified to work as a part of the rke2 embedded chart tesitng
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations
Backporting considerations