Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] rancher-vsphere-csi add 104.0.0+up3.1.2-rancher4 #3806

Conversation

HarrisonWAffel
Copy link
Contributor

Issue: rancher/rancher#45093

Problem

The vSphere CSI chart has updated the default value of csiAuthCheck

Solution

Bump the commit used in the vSphere CSI chart to introduce the updated default value

Testing

Testing has been done in the scope of rancher/rancher#45093 and the default value change has been verified to work as a part of the rke2 embedded chart tesitng

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@HarrisonWAffel HarrisonWAffel requested review from a team as code owners April 18, 2024 17:22

This comment was marked as outdated.

@HarrisonWAffel HarrisonWAffel force-pushed the 2.9-bump-vsphere-chart-with-new-defaults branch from f5ffa51 to 704be22 Compare April 18, 2024 17:33

This comment was marked as outdated.

@HarrisonWAffel HarrisonWAffel force-pushed the 2.9-bump-vsphere-chart-with-new-defaults branch from 704be22 to dfb4d2d Compare April 18, 2024 18:17

This comment was marked as outdated.

@HarrisonWAffel HarrisonWAffel force-pushed the 2.9-bump-vsphere-chart-with-new-defaults branch from dfb4d2d to ffa5a87 Compare April 18, 2024 18:40

This comment was marked as outdated.

@HarrisonWAffel HarrisonWAffel force-pushed the 2.9-bump-vsphere-chart-with-new-defaults branch from ffa5a87 to a9e2d3d Compare April 18, 2024 19:19
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@lucasmlp lucasmlp changed the title [v2.9] bump vSphere CSI chart to update defaults [dev-v2.9] rancher-vsphere-csi add 104.0.0+up3.1.2-rancher4 Apr 18, 2024
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@HarrisonWAffel HarrisonWAffel merged commit 3bb9483 into rancher:dev-v2.9 Apr 18, 2024
7 checks passed
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request May 14, 2024
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants