Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.7] rancher-monitoring 102.0.4-rc1+up40.1.2 update #3812

Merged

Conversation

HarrisonWAffel
Copy link
Contributor

Issue: rancher/windows#222

Problem

Various components of Rancher are using Windows images which contain Foreign Layer references. This makes mirroring these images more difficult and is a common source of user confusion when configuring windows nodes in air-gapped environments. Other PRs to rancher/rancher and rancher-monitoring on 2.8 and 2.9 have already resulted in many of these images being fixed, however monitoring on 2.7 has not yet been addressed.

Solution

  • Bump rancher/windows_exporter-package to v0.0.5
    • v0.0.5 is simply a rebuilt version of v0.0.3 which no longer contains foreign layer references. There is no functional difference between the two.

Testing

I've confirmed the chart can be installed and work as expected. I've confirmed the image does not contain foreign layers.

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@HarrisonWAffel HarrisonWAffel requested a review from a team as a code owner April 18, 2024 21:20
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@lucasmlp lucasmlp changed the title [v2.7] Bump windows node exporter version to remove foreign layers [dev-v2.7] rancher-monitoring 102.0.4-rc1+up40.1.2 update Apr 18, 2024
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@HarrisonWAffel HarrisonWAffel merged commit 9359467 into rancher:dev-v2.7 Apr 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants