Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] rancher-monitoring 104.0.0-rc1 update #3835

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Apr 29, 2024

Issue:

Dependency updates for PushProx

Changelog

Problem

PushProx has out of date dependencies and has migrated to github actions which has modified the way docker manifests are published slightly.

There have been no functional changes to PushProx besides dependency upgrades.

Context

Rancher pushprox is used inside of rancher-monitoring to federate access to protected metric endpoints in a safe manner, such as control plane metrics and node-exporter metrics in RKE2 / K3s.

Testing

The testing should revolve around testing rancher-monitoring in RKE2 and K3s and making sure the core metrics show up in dashboards, as well as verifying dashboards for integrations such as kube-state-metrics

Engineering Testing

Manual Testing

Tested pull-able docker images and helm template testing making sure the image tag has been properly updated

Automated Testing

PushProx CI.

QA Testing Considerations

  • Verifying dashboards work in RKE2/K3s
  • Verifying linux/amd64 and linux/arm64 setups for RKE2/K3s since docker manifests were modified slightly (verifying the images are pullable and run without issues on arm64 should be sufficient)

Regressions Considerations

  • Grafana dashboards, containers running on linux/arm64

Backporting considerations

  • dev-v2.8
  • dev-v2.7

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@alexandreLamarre alexandreLamarre marked this pull request as ready for review April 29, 2024 22:10
@alexandreLamarre alexandreLamarre requested a review from a team as a code owner April 29, 2024 22:10
@alexandreLamarre alexandreLamarre merged commit 4b4ee3f into rancher:dev-v2.9 Apr 30, 2024
6 checks passed
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request May 14, 2024
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request Jul 15, 2024
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants