Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-v2.7] Bump rancher webhook to v0.3.8-rc1 #3836

Merged
merged 3 commits into from
Apr 30, 2024
Merged

[dev-v2.7] Bump rancher webhook to v0.3.8-rc1 #3836

merged 3 commits into from
Apr 30, 2024

Conversation

JonCrowther
Copy link
Contributor

No description provided.

@JonCrowther JonCrowther self-assigned this Apr 29, 2024
@JonCrowther JonCrowther requested review from a team as code owners April 29, 2024 18:10
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@lucasmlp lucasmlp changed the title Bump rancher webhook to v0.3.8-rc1 [dev-v2.7] Bump rancher webhook to v0.3.8-rc1 Apr 30, 2024
lucasmlp
lucasmlp approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JonCrowther JonCrowther merged commit ce6eda5 into rancher:dev-v2.7 Apr 30, 2024
7 checks passed
@JonCrowther JonCrowther deleted the bump-rancher-webhook-v0.3.8-rc1 branch April 30, 2024 19:00
@JonCrowther JonCrowther mentioned this pull request Apr 30, 2024
Merged
lucasmlp pushed a commit that referenced this pull request May 9, 2024
@JonCrowther @lucasmlp
[dev-v2.7] Bump rancher webhook to v0.3.8-rc1 (#3836)
96630b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MbolotSuse MbolotSuse MbolotSuse approved these changes

@lucasmlp lucasmlp lucasmlp approved these changes

Assignees

@JonCrowther JonCrowther

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonCrowther @lucasmlp @MbolotSuse