Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] rancher-logging k8s 1.29 & 1.30 support #3908

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

mallardduck
Copy link
Member

@mallardduck mallardduck commented May 13, 2024

Issue:

rancher/rancher#45356
rancher/rancher#45335

Problem

For Rancher 2.9.x we need to support K8S 1.29 and 1.30

Solution

Adjust the kubeVersion of the chart to support the window of K8S versions Rancher 2.9.X will support.

Testing

Logging should be able to install on 2.9.x build using 1.29 or 1.30 cluster.
Specifically after this is merged version 104.0.0-rc1 of logging will support 1.29 or 1.30 clusters.

Engineering Testing

Manual Testing

Successfully installed on 1.29 and 1.30 downstream clusters.

Automated Testing

QA Testing Considerations

We found an existing open issue in r/r that matches the issue I've encountered in my testing. rancher/rancher#38730

Because this is an existing issue and not technically an issue with installing the logging chart on 1.29 this is not going to be treated as a blocker for this PR. Once I rebase it and do a quick retest after that I will undraft it for review.

Regressions Considerations

PSP related things are vestigial at this point - the minimum k8s version is 1.26.
However, unsure if we should begin removing them as they come from upstream.

Backporting considerations

Nope - only for Rancher 2.9.x

@mallardduck mallardduck requested a review from a team as a code owner May 13, 2024 17:23
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck mallardduck marked this pull request as draft May 13, 2024 19:49
@mallardduck
Copy link
Member Author

Currently investigating 2 (seemingly related) issues with the chart on 2.9 alpha2.

When trying to create a ClusterOutput:

ClusterOutput.logging.banzaicloud.io “cluster-output-syslog” is invalid: spec.syslog.buffer: Invalid value: “string”: spec.syslog.buffer in body must be of type object: “string”

And in the same process on the "Output buffer" tab:

Error loading schema for logging.banzaicloud.io.v1beta1.output.spec.awsElasticsearch.buffer

@mallardduck
Copy link
Member Author

We found an existing open issue in r/r that matches the issue I've encountered in my testing. rancher/rancher#38730

Because this is an existing issue and not technically an issue with installing the logging chart on 1.29 this is not going to be treated as a blocker for this PR. Once I rebase it and do a quick retest after that I will undraft it for review.

@pankajsqe - You may want to keep this in mind for testing that UI creation of Output/ClusterOutput will have this issue until triaged and fixed by UI team.

@mallardduck mallardduck marked this pull request as ready for review June 5, 2024 17:10
Copy link

github-actions bot commented Jun 5, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck mallardduck merged commit 900ac45 into rancher:dev-v2.9 Jun 6, 2024
6 checks passed
skanakal pushed a commit to skanakal/charts that referenced this pull request Jun 7, 2024
@alexandreLamarre
Copy link
Contributor

@mallardduck @pankajsqe UI issue might be related to open API schema bugs mentionned in rancher/rancher#45157 or rancher/rancher#45158.

krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants