-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.9] rancher-monitoring fix crd update/delete #3998
Merged
alexandreLamarre
merged 2 commits into
rancher:dev-v2.9
from
alexandreLamarre:fix-rancher-monitoring-crd-29
Jun 6, 2024
Merged
[dev-v2.9] rancher-monitoring fix crd update/delete #3998
alexandreLamarre
merged 2 commits into
rancher:dev-v2.9
from
alexandreLamarre:fix-rancher-monitoring-crd-29
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
alexandreLamarre
changed the title
Fix rancher monitoring crd 29
[dev-v2.9] rancher-monitoring fix crd update/delete
Jun 3, 2024
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
alexandreLamarre
force-pushed
the
fix-rancher-monitoring-crd-29
branch
from
June 4, 2024 17:04
165450e
to
c3728fa
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
1 similar comment
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
joshmeranda
approved these changes
Jun 6, 2024
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
alexandreLamarre
force-pushed
the
fix-rancher-monitoring-crd-29
branch
from
June 6, 2024 16:42
721d3b7
to
f23ad0b
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
skanakal
pushed a commit
to skanakal/charts
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
krunalhinguu
pushed a commit
to krunalhinguu/charts
that referenced
this pull request
Jul 15, 2024
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#45575
rancher/rancher#45167
Problem
rancher-monitoring crd update/delete will fail on the first try
Solution
Add required permissions
Testing
QA Testing Considerations
Update (from one version to another) / delete rancher-monitoring crd should pass
Regressions Considerations
Backporting considerations
v2.7, v2.8, v2.9