Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] rancher-monitoring fix crd update/delete #3998

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Jun 3, 2024

Issue:

rancher/rancher#45575
rancher/rancher#45167

Problem

rancher-monitoring crd update/delete will fail on the first try

Solution

Add required permissions

Testing

QA Testing Considerations

Update (from one version to another) / delete rancher-monitoring crd should pass

Regressions Considerations

Backporting considerations

v2.7, v2.8, v2.9

Copy link

github-actions bot commented Jun 3, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@alexandreLamarre alexandreLamarre changed the title Fix rancher monitoring crd 29 [dev-v2.9] rancher-monitoring fix crd update/delete Jun 3, 2024
Copy link

github-actions bot commented Jun 4, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@alexandreLamarre alexandreLamarre marked this pull request as ready for review June 4, 2024 16:46
@alexandreLamarre alexandreLamarre requested a review from a team as a code owner June 4, 2024 16:46
Copy link

github-actions bot commented Jun 4, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

1 similar comment
Copy link

github-actions bot commented Jun 5, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Copy link

github-actions bot commented Jun 6, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@alexandreLamarre alexandreLamarre merged commit b74c767 into rancher:dev-v2.9 Jun 6, 2024
5 checks passed
skanakal pushed a commit to skanakal/charts that referenced this pull request Jun 7, 2024
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
@pankajsqe
Copy link

Rancher monitoring charts are getting deleted successfully.

Screenshot 2024-06-07 at 8 14 23 PM

krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request Jul 15, 2024
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants