Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v2.8] Solo batch for release 2.8.5 rancher-webhook 103.0.5+up0.4.6 and forward-port 2.0.10+up0.3.10 #4074

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

nicholasSUSE
Copy link
Collaborator

@nicholasSUSE nicholasSUSE commented Jun 12, 2024

Charts:

rancher-webhook 103.0.5+up0.4.6:

rancher-webhook 2.0.10+up0.3.10:

Charts Checklist (built for v0.8.1 charts-build-scripts)

Checkpoint 0: Validate release.yaml

Validation steps:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

  • Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

  • The index.yaml file has an entry for each chart version.
  • The index.yaml entries for each chart matches the Chart.yaml for each chart.
  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

nicholasSUSE and others added 4 commits June 12, 2024 14:28
Signed-off-by: Guilherme Macedo <guilherme@gmacedo.com>
All checks succeeded, I reviewed myself and I am approving and merging with admin permissions.
There is nobody yet to help me review this.
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@nicholasSUSE
Copy link
Collaborator Author

I reviewed and approved this request, but I have not yet trained anybody to review it with me.
The approval from someone on the release team is my responsibility, I need it to run a CI job.

@nicholasSUSE nicholasSUSE added the regsync-ready PR ready to sync images with prime registry label Jun 12, 2024
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@nicholasSUSE nicholasSUSE merged commit 214052f into release-v2.8 Jun 12, 2024
5 checks passed
@nicholasSUSE nicholasSUSE deleted the solo-batch-2.8.5 branch June 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regsync-ready PR ready to sync images with prime registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants