Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] Disable event tailer pvc #4328

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

joshmeranda
Copy link
Contributor

Issue:

Problem

Rebasing rancher-logging introduced a new feature to support storing event logs on pvc which is enabled by default. This broke some installs in a way that was not caught by developer testing.

Solution

Disable pvc feature by default.

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@joshmeranda joshmeranda requested a review from a team as a code owner August 9, 2024 13:19
Copy link

github-actions bot commented Aug 9, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@joshmeranda joshmeranda merged commit a97127a into rancher:dev-v2.9 Aug 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants