Re-enable machine pools validation

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
rancher · Aug 9, 2024 · 7d8d4d4 · 7d8d4d4
1 parent 578e44d
commit 7d8d4d4
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/pkg/harvester-manager/machine-config/harvester.vue b/pkg/harvester-manager/machine-config/harvester.vue
@@ -609,6 +609,8 @@ export default {
 
       this.validatorDiskAndNetowrk(errors);
 
+      this.validatorVGpus(errors);
+
       podAffinityValidator(this.vmAffinity.affinity, this.$store.getters, errors);
 
       return { errors };
@@ -676,6 +678,38 @@ export default {
       }
     },
 
+    validatorVGpus(errors) {
+      const notAllocatable = this.vGpus
+        .map((type) => {
+          const allocated = this.machinePools.reduce((acc, machinePool) => {
+            const vGPURequests = JSON.parse(machinePool?.config?.vgpuInfo || '')?.vGPURequests;
+
+            const vGpuTypes = vGPURequests?.map((r) => r?.deviceName).filter((f) => f) || [];
+
+            if (vGpuTypes.includes(type)) {
+              return acc + machinePool.pool.quantity;
+            }
+
+            return acc;
+          }, 0);
+
+          return {
+            vGpu: Object.values(this.vGpuDevices).filter((f) => f.type === type)?.[0],
+            allocated
+          }
+        })
+        .filter(({ vGpu, allocated }) => vGpu && vGpu.allocatable > 0 && vGpu.allocatable < allocated);
+
+      notAllocatable.forEach(({ vGpu, allocated }) => {
+        const message = this.$store.getters['i18n/t']('cluster.credential.harvester.vGpus.errors.notAllocatable', {
+          vGpu: vGpu?.type,
+          allocated,
+          allocatable: vGpu?.allocatable
+        });
+        errors.push(message);
+      });
+    },
+
     valuesChanged(value, type) {
       this.value[type] = base64Encode(value);
     },

diff --git a/shell/assets/translations/en-us.yaml b/shell/assets/translations/en-us.yaml
@@ -1357,6 +1357,9 @@ cluster:
         networkName: Network Name
         macAddress: Mac Address
         macFormat: 'Invalid MAC address format.'
+      vGpus:
+        errors:
+          notAllocatable: '[{vGpu}] vGPU device is not allocatable; required: {allocated}, allocatable: {allocatable}'
       volume:
         title: Volumes
         volume: Volume