[backport 2.8] Add vGPU allocatable warning banner #11600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaktive
reviewed
Aug 14, 2024
shell/assets/translations/en-us.yaml
Outdated
| @@ -1279,6 +1279,8 @@ cluster: | |||
| macAddress: Mac Address | |||
| macFormat: 'Invalid MAC address format.' | |||
| vGpus: | |||
| warnings: | |||
| minimumAllocatable: It's highly recommended to select a vGPU with a number of allocatable devices greater then the number of nodes (Machine Count) to avoid "un-schedulable" errors after cluster updates. | |||
There was a problem hiding this comment.
Similar to feedback on the 2.10 & 2.9 related PRs:
thenshould be thanvGPUshould be used with that capitalization for consistency
gaktive
reviewed
Aug 14, 2024
shell/assets/translations/en-us.yaml
Outdated
| @@ -1279,6 +1279,8 @@ cluster: | |||
| macAddress: Mac Address | |||
| macFormat: 'Invalid MAC address format.' | |||
| vGpus: | |||
| warnings: | |||
| minimumAllocatable: It's highly recommended to select a vGPU with a number of allocatable devices greater then the number of nodes (Machine Count) to avoid "un-schedulable" errors after cluster updates. | |||
| errors: | |||
| notAllocatable: '"VGPUs" not allocatable. There are not enough [{vGpus}] devices to be allocated to each node in machine pool [{pool}]' | |||
jordojordo
approved these changes
Aug 14, 2024
|
@a110605 let us know if there's anything else for you to look at here since with Francesco out, we'll need someone else to merge. If you feel everything's OK based on your own concerns, then you can approve & merge. |
Hi @gaktive , the vGPU allocatable number in dropdown is introduced in PR #11399. Without #11399, the banner in this PR is meanless. As I synced with Franesco last time, this PR should wait for #11399 merge first. (correct me if I'm wrong) |
torchiaf
changed the title
torchiaf
changed the title
torchiaf
force-pushed
the
backport-2-8-11017
branch
from
cb01f91
to
c0b51d4
Compare
- Add vGPU allocatable warning banner - Update shell/assets/translations/en-us.yaml - Fix wording - Show allocation warning only when allocation info are available Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
torchiaf
force-pushed
the
backport-2-8-11017
branch
from
c0b51d4
to
47e5dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport for #11017
Fixes #11009