-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Storybook components do not render correctly after migration #12594
Draft
cnotv
wants to merge
35
commits into
rancher:master
Choose a base branch
from
cnotv:feature/12139-storybook-rendering-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Some Storybook components do not render correctly after migration #12594
cnotv
wants to merge
35
commits into
rancher:master
from
cnotv:feature/12139-storybook-rendering-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnotv
changed the title
Feature/12139 storybook rendering fix
Some Storybook components do not render correctly after migration
Nov 13, 2024
cnotv
force-pushed
the
feature/12139-storybook-rendering-fix
branch
from
November 13, 2024 20:48
c884c61
to
6e2281b
Compare
cnotv
force-pushed
the
feature/12139-storybook-rendering-fix
branch
from
November 14, 2024 19:14
6e2281b
to
91672b5
Compare
cnotv
force-pushed
the
feature/12139-storybook-rendering-fix
branch
from
November 14, 2024 21:50
91672b5
to
d7cc50a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11707
Occurred changes and/or fixed issues
*.story.ts
(markup and logic) and.mdx
(documentation, if none this is automatically generated)storybook-vue3-router
decoratorTechnical notes summary
Many components had some extra logic out of the box. This goes diametrically opposite to the style guide concept, as it should just demonstrate functionalities and use cases, not writing code. Features should work in standalone and out of the box.
Areas or cases that should be tested
Run
yarn storybook
after installing the packagesAreas which could experience regressions
Screenshot/Video
Kapture.2024-11-13.at.18.47.39.mp4
Checklist