-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: make sure metrics work well with sharding #2355
Comments
Note: this documentation on how Flux had planned to do it may be useful. |
p-se
added a commit
to p-se/fleet
that referenced
this issue
May 8, 2024
p-se
added a commit
to p-se/fleet
that referenced
this issue
May 8, 2024
p-se
added a commit
to p-se/fleet
that referenced
this issue
May 8, 2024
p-se
added a commit
to p-se/fleet
that referenced
this issue
May 17, 2024
p-se
added a commit
to p-se/fleet
that referenced
this issue
May 21, 2024
p-se
added a commit
to p-se/fleet
that referenced
this issue
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to ensure that metrics are collected against resources reconciled not just by the unsharded Fleet controller, but also by sharded controllers.
This could be an opportunity to improve shard label naming, for instance by supporting label-based filtering on the unsharded controller (currently not possible with an emptyshard
value). For instance, we could use~
instead of an empty string, or simply add a label such asfleet.cattle.io/empty-shard=true
or similar.A new label
shard-default
with valuetrue
for the unsharded controller has been implemented in 436a81d as part of the PR with the implementation of metrics #2172. Metrics still does not work with sharded fleet controllers. This is to be remedied.This is a follow-up on both #1740 and #1408.
The text was updated successfully, but these errors were encountered: