metrics: make sure metrics work well with sharding #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-se
force-pushed
the
metrics-with-sharding
branch
from
b4ffd42
to
8ede86a
Compare
manno
reviewed
May 15, 2024
manno
previously requested changes
May 16, 2024
weyfonk
reviewed
May 17, 2024
p-se
force-pushed
the
metrics-with-sharding
branch
from
8ede86a
to
ea11777
Compare
p-se
force-pushed
the
metrics-with-sharding
branch
from
ea11777
to
65864e0
Compare
weyfonk
reviewed
May 21, 2024
p-se
force-pushed
the
metrics-with-sharding
branch
from
65864e0
to
9807f35
Compare
weyfonk
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #2355