Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Update master-e2e.yaml to use updated instance template #5

Closed
wants to merge 1 commit into from
Closed

WIP: Update master-e2e.yaml to use updated instance template #5

wants to merge 1 commit into from

Conversation

valaparthvi
Copy link
Collaborator

@valaparthvi valaparthvi commented Dec 13, 2023 •
edited
Loading

This PR updates the action with newer instance template that has no elemental zypper repo.

https://github.com/rancher-sandbox/rancher-turtles-e2e/actions/runs/7206427104

@valaparthvi valaparthvi changed the title Update master-e2e.yaml to use updated instance template WIP: Update master-e2e.yaml to use updated instance template Dec 13, 2023
@valaparthvi valaparthvi requested a review from juadk December 13, 2023 10:51
@valaparthvi valaparthvi changed the title WIP: Update master-e2e.yaml to use updated instance template Update master-e2e.yaml to use updated instance template Dec 13, 2023
@valaparthvi valaparthvi requested a review from cpinjani December 13, 2023 12:00
@juadk
Copy link
Collaborator

juadk commented Dec 13, 2023

I think you have to rebase your PR from main to make the test green. (to pull last Chandan's code)

@valaparthvi
Update master-e2e.yaml to use updated instance template
a9fc6c4 
This PR updates the action with newer instance template that uses opensuse 15.5 and no elemental zypper repo

Signed-off-by: Parthvi Vala <parthvi.vala@gmail.com>

Update master-e2e.yaml

Signed-off-by: Parthvi Vala <parthvi.vala@gmail.com>
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
@valaparthvi
Copy link
Collaborator Author

I think you have to rebase your PR from main to make the test green. (to pull last Chandan's code)

It is up to date. Now all I need is 1 approval.

@juadk
Copy link
Collaborator

juadk commented Dec 14, 2023

I think you have to rebase your PR from main to make the test green. (to pull last Chandan's code)

It is up to date. Now all I need is 1 approval.

May you retrigger the job with the updated code? and update the description with the job's link, please.

@valaparthvi
Copy link
Collaborator Author

I think you have to rebase your PR from main to make the test green. (to pull last Chandan's code)

It is up to date. Now all I need is 1 approval.

May you retrigger the job with the updated code? and update the description with the job's link, please.

It's done. 2.8 passed.

@valaparthvi valaparthvi changed the title Update master-e2e.yaml to use updated instance template WIP: Update master-e2e.yaml to use updated instance template Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juadk juadk Awaiting requested review from juadk

@cpinjani cpinjani Awaiting requested review from cpinjani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valaparthvi @juadk