Log underlying error when YAML generation fails #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vicente-Cheng
approved these changes
Jul 3, 2024
|
@ejweber, could you help to rebase for the conflict? |
support-bundle-kit 99 Signed-off-by: Eric Weber <eric.weber@suse.com>
ejweber
force-pushed
the
99-log-discovery-errors
branch
from
e914ff7
to
65bf721
Compare
|
It looks like @ibrokethecloud beat me to some of these locations, but I think these errors also make sense in the error log, so we should move forward with the changes IMO. Rebased and fixed conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99 with best-effort.
I can't actually manage to hit an error like the on from #99 (comment) in my cluster. I tried mangling the
cluster-adminClusterRole to remove access to nonResourceURLs and removing thesystem:discoveryClusterRoleBinding in an attempt to stop support-bundle-manager from using the Kubernetes Discovery API. This DID result in a support bundle without YAML files, but did not trigger theUnable to fetch cluster resourcesmessage (in either a modified or unmodified support-bundle-kit). This means I cannot actually show the result of this PR in action. However, it should provide us additional debugging information if the YAML collection fails again like this in the future.