Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix arm64 #105

Merged
merged 3 commits into from
Apr 10, 2024
Merged

ci: fix arm64 #105

merged 3 commits into from
Apr 10, 2024

Conversation

Yu-Jack
Copy link
Collaborator

@Yu-Jack Yu-Jack commented Apr 9, 2024

fix build-args issue

related issue: harvester/harvester#5327

Signed-off-by: Jack Yu <jack.yu@suse.com>
@Yu-Jack Yu-Jack self-assigned this Apr 9, 2024
@Yu-Jack Yu-Jack requested review from bk201 and removed request for bk201 April 9, 2024 15:18
Signed-off-by: Jack Yu <jack.yu@suse.com>
Signed-off-by: Jack Yu <jack.yu@suse.com>
@Yu-Jack Yu-Jack requested a review from bk201 April 10, 2024 02:34
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@bk201
Copy link
Member

bk201 commented Apr 10, 2024

A side note: we need to change DRONE_TAG after switching to Github Action :

GIT_TAG=${DRONE_TAG:-$(git tag -l --contains HEAD | head -n 1)}

@Yu-Jack Yu-Jack merged commit 9565f65 into rancher:master Apr 10, 2024
4 checks passed
@Yu-Jack Yu-Jack deleted the feat-5372-arm64 branch April 10, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants