ci: simplify the script/package to speed up local development #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yu-Jack
force-pushed
the
ci-test
branch
2 times, most recently
from
6a9d138
to
9a68da7
Compare
Yu-Jack
changed the title
Signed-off-by: Jack Yu <jack.yu@suse.com>
Yu-Jack
commented
Apr 18, 2024
Yu-Jack
commented
Apr 18, 2024
| @@ -1,6 +1,9 @@ | |||
| # syntax=docker/dockerfile:1.7.0 | |||
There was a problem hiding this comment.
This syntax is for this error ERROR: failed to solve: failed to process “${TARGETPLATFORM#linux/}“: unsupported modifier (#) in substitution when running ./scripts/packge locally.
doc - https://docs.docker.com/reference/dockerfile/#environment-replacement
bk201
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested following situations, all work:
Through this change, it can speed up the local development which run ./scripts/package without waiting multiple platform build, and the image is still usable in linux/amd64 and linux/arm64.
Related Issue: harvester/harvester#5327