Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Golang to v1.21 and remove Harvester dependency #111

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Yu-Jack
Copy link
Collaborator

@Yu-Jack Yu-Jack commented Apr 22, 2024

Problem

When I run go list -m -mod=mod all, it shows following errors.

go: github.com/honestbee/jobq@v1.0.2: invalid version: git ls-remote -q origin in /Users/{user}/.gvm/pkgsets/go1.20/global/pkg/mod/cache/vcs/b7039093cfd5e54747139d9a392f45ffb733fb74488bd673022aa3b33e2ae79f: exit status 128:
        ERROR: Repository not found.
        fatal: Could not read from remote repository.
        
        Please make sure you have the correct access rights
        and the repository exists.
go: k8s.io/dynamic-resource-allocation@v0.0.0: invalid version: unknown revision v0.0.0

After checking some dependency of Harvester, we only used v1beta1.ErrorResponse (path is pkg/utils/http.go). So, I think we don't need to rely on it, just create own struct to remove dependency. Then Golang should be bumped to v1.21 due to EOL.

Test

  • I tested collecting support bundle file and running simulator, both are fine.

@Yu-Jack Yu-Jack requested a review from bk201 April 22, 2024 06:15
@Yu-Jack Yu-Jack self-assigned this Apr 22, 2024
@Yu-Jack Yu-Jack changed the title bump: Golang to v1.21 and Harvester to v1.3.0 bump: Golang to v1.21 and remove harvester dependency Apr 22, 2024
@Yu-Jack Yu-Jack changed the title bump: Golang to v1.21 and remove harvester dependency bump: Golang to v1.21 and remove Harvester dependency Apr 22, 2024
@Yu-Jack Yu-Jack removed the request for review from bk201 April 22, 2024 06:18
Signed-off-by: Jack Yu <jack.yu@suse.com>
Copy link
Collaborator

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@bk201 bk201 merged commit 46b72a9 into rancher:master Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants