Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove useless build args #112

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

Yu-Jack
Copy link
Collaborator

@Yu-Jack Yu-Jack commented Apr 24, 2024

I copied this from Drone config before, but I realized VERSION not used in Dockerfile.

BTW, because we changed it from ARG ARCH to ENV ARCH in Dockerfile due to using buildx which provides TARGETPLATFORM.

Signed-off-by: Jack Yu <jack.yu@suse.com>
@Yu-Jack Yu-Jack self-assigned this Apr 24, 2024
@Yu-Jack
Copy link
Collaborator Author

Yu-Jack commented Apr 24, 2024

@ibrokethecloud I noticed I didn't remove it here, just a quick minor fix.

@Yu-Jack Yu-Jack requested a review from bk201 April 25, 2024 02:42
@Yu-Jack Yu-Jack merged commit f211058 into rancher:master Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants