Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collector: improve the log time format #117

Merged
merged 1 commit into from
Jun 20, 2024
Merged

collector: improve the log time format #117

merged 1 commit into from
Jun 20, 2024

Conversation

Vicente-Cheng
Copy link
Contributor 

- Now we can get more accurate timestamp

Related issue: harvester/harvester#6043

@Vicente-Cheng
collector: improve the log time format
a081e68 
    - Now we can get more accurate timestamp

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
@Vicente-Cheng
Copy link
Contributor Author

Hi @c3y1huang,

After this PR some logs (fetching from journalctl) will look like below:

Jun 19 10:25:27.108450 harvester-node-0 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
Jun 19 10:31:22.968576 harvester-node-0 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
Jun 20 03:56:52.212464 harvester-node-0 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready

The previous would be like:

Jun 19 10:25:27 harvester-node-0 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
Jun 19 10:31:22 harvester-node-0 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
Jun 20 03:56:52 harvester-node-0 kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready

Does it cause any impact on the Longhorn support bundle side?

Yu-Jack
Yu-Jack reviewed Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@Yu-Jack Yu-Jack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one curious thing.

package/Dockerfile Show resolved Hide resolved
@c3y1huang
Copy link
Collaborator

Does it cause any impact on the Longhorn support bundle side?

No, this change is good. Thank you.

@c3y1huang c3y1huang merged commit 366d823 into rancher:master Jun 20, 2024
1 check passed
@Vicente-Cheng Vicente-Cheng deleted the improve-timestamp-format branch June 20, 2024 11:51
@Vicente-Cheng Vicente-Cheng mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@Yu-Jack Yu-Jack Yu-Jack approved these changes

@c3y1huang c3y1huang c3y1huang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vicente-Cheng @c3y1huang @bk201 @Yu-Jack