fix(agent): should respect taint-toleration #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3y1huang
force-pushed
the
fix-support-bundle-agent-missing-nodeselector-taintolerate
branch
2 times, most recently
from
eb310ac
to
aa95566
Compare
c3y1huang
changed the title
c3y1huang
changed the title
|
The Harvester backend needs to adapt this change, tracked in harvester/harvester#3702. |
bk201
reviewed
Mar 22, 2023
c3y1huang
force-pushed
the
fix-support-bundle-agent-missing-nodeselector-taintolerate
branch
5 times, most recently
from
4710297
to
fa3517d
Compare
Ref: 57, Longhorn-5614 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Ref: 57, Longhorn-5614 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Ref: 57, Longhorn-5614 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang
force-pushed
the
fix-support-bundle-agent-missing-nodeselector-taintolerate
branch
from
fa3517d
to
ff87893
Compare
innobead
approved these changes
Apr 6, 2023
| Operator: corev1.TolerationOpExists, | ||
| }, | ||
| }, | ||
| Tolerations: a.sbm.getTaintToleration(), |
There was a problem hiding this comment.
Just a note: This will change the current behavior if no taint tolerations are specified since it was to tolerate all taints.
c3y1huang
deleted the
fix-support-bundle-agent-missing-nodeselector-taintolerate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57
longhorn/longhorn#5614