Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agent): tainted nodes should not be counted #70

Merged
merged 3 commits into from
Apr 14, 2023
Merged

fix(agent): tainted nodes should not be counted #70

merged 3 commits into from
Apr 14, 2023

Conversation

c3y1huang
Copy link
Collaborator

@c3y1huang c3y1huang self-assigned this Apr 13, 2023
@c3y1huang c3y1huang marked this pull request as ready for review April 13, 2023 09:33
@c3y1huang c3y1huang mentioned this pull request Apr 13, 2023
Closed
innobead
innobead requested changes Apr 13, 2023
View reviewed changes
Copy link

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM. However, as I commented, we can just use the desired number of pods for the agent DS directly w/o any checks.

pkg/manager/manager.go Outdated Show resolved Hide resolved
innobead
innobead requested changes Apr 14, 2023
View reviewed changes
pkg/manager/manager.go Outdated Show resolved Hide resolved
pkg/manager/manager.go Outdated Show resolved Hide resolved
pkg/manager/manager.go Outdated Show resolved Hide resolved
@c3y1huang c3y1huang force-pushed the fix-should-not-count-tainted-nodes-as-expected-nodes branch 6 times, most recently from c586511 to 58daddd Compare April 14, 2023 03:09
innobead
innobead reviewed Apr 14, 2023
View reviewed changes
pkg/types/types.go Outdated Show resolved Hide resolved
@c3y1huang c3y1huang force-pushed the fix-should-not-count-tainted-nodes-as-expected-nodes branch 3 times, most recently from 0e95962 to 0e33ceb Compare April 14, 2023 06:12
@c3y1huang
fix(agent): tainted nodes should not be counted
ccf2d2d 
Ref: 57, Longhorn-5614

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the fix-should-not-count-tainted-nodes-as-expected-nodes branch from 0e33ceb to 3235cbd Compare April 14, 2023 06:25
@c3y1huang
chore: cleanup imports
0b32989 
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang
style: capitalize first word in log messages
73fc526 
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the fix-should-not-count-tainted-nodes-as-expected-nodes branch from 3235cbd to 73fc526 Compare April 14, 2023 07:03
innobead
innobead approved these changes Apr 14, 2023
View reviewed changes
Copy link

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@innobead innobead merged commit ef90a2c into rancher:master Apr 14, 2023
@c3y1huang c3y1huang deleted the fix-should-not-count-tainted-nodes-as-expected-nodes branch April 14, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

@bk201 bk201 Awaiting requested review from bk201

@ibrokethecloud ibrokethecloud Awaiting requested review from ibrokethecloud

Assignees

@c3y1huang c3y1huang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c3y1huang @innobead