✨Separate rancher cluster from manager #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
separate-rancher-cluster-from-manager
branch
4 times, most recently
from
4c83402
to
65f485e
Compare
|
This works, but the problem is with integration tests. Envtest client can’t find created resource by the controller during the test run. At the same time |
Danil-Grigorev
force-pushed
the
separate-rancher-cluster-from-manager
branch
from
65f485e
to
738bcd3
Compare
Danil-Grigorev
force-pushed
the
separate-rancher-cluster-from-manager
branch
2 times, most recently
from
a5ff0f9
to
f37436e
Compare
Danil-Grigorev
changed the title
Danil-Grigorev
force-pushed
the
separate-rancher-cluster-from-manager
branch
4 times, most recently
from
9378211
to
ced3c4a
Compare
- Add tests for 2 cluster CAPI import setup Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
separate-rancher-cluster-from-manager
branch
from
ced3c4a
to
6bca0d8
Compare
|
I’m going to close this for now, as merging this does not seem to be a priority yet, but the approach implemented here is the best shot for multi-cluster scenario support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/feature
What this PR does / why we need it:
This is an implementation for a multi cluster setup using cluster interface from controller-runtime.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: