Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Providers api controller implementation #293

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Dec 4, 2023

What this PR does / why we need it

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #286

Depends on #292

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner December 4, 2023 09:38
@Danil-Grigorev Danil-Grigorev force-pushed the providers_api_controller_implementation branch from 649f65c to 7d44fef Compare December 4, 2023 09:41
@Danil-Grigorev Danil-Grigorev force-pushed the providers_api_controller_implementation branch 7 times, most recently from 67fb475 to eeda535 Compare December 12, 2023 12:12
@richardcase richardcase dismissed alexander-demicev’s stale review December 12, 2023 15:49

The merge-base changed after approval.

@Danil-Grigorev Danil-Grigorev force-pushed the providers_api_controller_implementation branch from eeda535 to c6dec46 Compare December 12, 2023 15:52
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
@Danil-Grigorev Danil-Grigorev force-pushed the providers_api_controller_implementation branch from c6dec46 to 410c702 Compare December 12, 2023 15:54
internal/sync/provider_sync.go Show resolved Hide resolved
@Danil-Grigorev Danil-Grigorev merged commit 45dcd49 into rancher:main Dec 12, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement controller for CAPIProvider CRD
4 participants