-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Providers api controller implementation #293
Merged
Danil-Grigorev
merged 5 commits into
rancher:main
from
Danil-Grigorev:providers_api_controller_implementation
Dec 12, 2023
Merged
✨Providers api controller implementation #293
Danil-Grigorev
merged 5 commits into
rancher:main
from
Danil-Grigorev:providers_api_controller_implementation
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
providers_api_controller_implementation
branch
from
December 4, 2023 09:41
649f65c
to
7d44fef
Compare
richardcase
reviewed
Dec 4, 2023
Danil-Grigorev
force-pushed
the
providers_api_controller_implementation
branch
7 times, most recently
from
December 12, 2023 12:12
67fb475
to
eeda535
Compare
alexander-demicev
previously approved these changes
Dec 12, 2023
richardcase
dismissed
alexander-demicev’s stale review
December 12, 2023 15:49
The merge-base changed after approval.
Danil-Grigorev
force-pushed
the
providers_api_controller_implementation
branch
from
December 12, 2023 15:52
eeda535
to
c6dec46
Compare
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
providers_api_controller_implementation
branch
from
December 12, 2023 15:54
c6dec46
to
410c702
Compare
richardcase
approved these changes
Dec 12, 2023
salasberryfin
approved these changes
Dec 12, 2023
alexander-demicev
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #286
Depends on #292
Special notes for your reviewer:
Checklist: