🌱 Add valid helm chart structure and helm templating support for the chart #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
added
the
kind/refactor
Danil-Grigorev
changed the title
Danil-Grigorev
force-pushed
the
value-substitution
branch
3 times, most recently
from
0e47aad
to
ab495b3
Compare
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
value-substitution
branch
from
ab495b3
to
96d1a07
Compare
Yes, it does, the charts/default directory is only used for that |
alexander-demicev
approved these changes
Aug 3, 2023
richardcase
approved these changes
Aug 22, 2023
furkatgofurov7
approved these changes
Aug 24, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Based on #55, depends on #58
Cleaning up and restructuring release process to provide a valid helm charts structure and templating. This allows a valid tag substitution in each release. Example release generated by this: https://github.com/Danil-Grigorev/rancher-turtles/releases/tag/rancher-turtles-1.2.29
To try it out:
helm repo add rancher-turtles-testing https://danil-grigorev.github.io/rancher-turtles helm repo update helm install test rancher-turtles-me/rancher-turtles --version 1.2.29Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: