-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme with more information about dev setup #61
Conversation
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
I will run this locally and come back here today. |
Thanks for this update. It's very useful for those of us that are starting to set the development environment for the first time. Just a minor typo I found in the README (I cannot propose a change because the line was not changed on this PR) in line 47:
We could use this PR to also fix this. 🙂 |
Running it in MacOS gives me cert manager error:
has anyone seen this also, or it is only in my local env? So basically, it can't properly install cert manager v1.12.3 but keep on and installs v1.11.0 and cert manager pods are running fine. |
@furkatgofurov7 I had the same cert-manager issue in Linux:
|
@salasberryfin looks like as suggested by error message, we need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few clarification questions inline, otherwise looks good to me, thanks!
a86f1f1
to
5f35a48
Compare
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
5f35a48
to
18f9a14
Compare
@salasberryfin @furkatgofurov7 I updated the PR, ptal |
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
18f9a14
to
e8a3924
Compare
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: