Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with more information about dev setup #61

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

alexander-demicev
Copy link
Member

@alexander-demicev alexander-demicev commented Aug 2, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
@alexander-demicev alexander-demicev added the kind/documentation Improvements or additions to documentation label Aug 2, 2023
@alexander-demicev alexander-demicev requested a review from a team as a code owner August 2, 2023 12:17
Danil-Grigorev
Danil-Grigorev previously approved these changes Aug 2, 2023
@furkatgofurov7
Copy link
Contributor

I will run this locally and come back here today.

@salasberryfin
Copy link
Contributor

Thanks for this update. It's very useful for those of us that are starting to set the development environment for the first time. Just a minor typo I found in the README (I cannot propose a change because the line was not changed on this PR) in line 47:

make dev-denv

We could use this PR to also fix this. 🙂

@furkatgofurov7
Copy link
Contributor

furkatgofurov7 commented Aug 7, 2023

Running it in MacOS gives me cert manager error:

Waiting for deployment "coredns" rollout to finish: 1 of 2 updated replicas are available...
deployment "coredns" successfully rolled out
Error: INSTALLATION FAILED: chart "cert-manager" matching v1.12.3 not found in jetstack index. (try 'helm repo update'): no chart version found for cert-manager-v1.12.3
Error from server (NotFound): namespaces "cert-manager" not found
Fetching providers
Installing cert-manager Version="v1.11.0"
Waiting for cert-manager to be available...
Installing Provider="cluster-api" Version="v1.5.0" TargetNamespace="capi-system"
Installing Provider="bootstrap-kubeadm" Version="v1.5.0" TargetNamespace="capi-kubeadm-bootstrap-system"
Installing Provider="control-plane-kubeadm" Version="v1.5.0" TargetNamespace="capi-kubeadm-control-plane-system"
Installing Provider="infrastructure-docker" Version="v1.5.0" TargetNamespace="capd-system"

Your management cluster has been initialized successfully!

You can now create your first workload cluster by running the following:

has anyone seen this also, or it is only in my local env?

So basically, it can't properly install cert manager v1.12.3 but keep on and installs v1.11.0 and cert manager pods are running fine.

@salasberryfin
Copy link
Contributor

@furkatgofurov7 I had the same cert-manager issue in Linux:

Error: INSTALLATION FAILED: chart "cert-manager" matching v1.12.3 not found in jetstack index. (try 'helm repo update'): no chart version found for cert-manager-v1.12.3

@furkatgofurov7
Copy link
Contributor

furkatgofurov7 commented Aug 7, 2023

@furkatgofurov7 I had the same cert-manager issue in Linux:

Error: INSTALLATION FAILED: chart "cert-manager" matching v1.12.3 not found in jetstack index. (try 'helm repo update'): no chart version found for cert-manager-v1.12.3

@salasberryfin looks like as suggested by error message, we need to add helm repo update before running helm install cert-manager and it is fixed for me.

Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few clarification questions inline, otherwise looks good to me, thanks!

internal/controllers/import_controller.go Show resolved Hide resolved
scripts/turtles-dev.sh Show resolved Hide resolved
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
@alexander-demicev
Copy link
Member Author

@salasberryfin @furkatgofurov7 I updated the PR, ptal

README.md Outdated Show resolved Hide resolved
salasberryfin
salasberryfin previously approved these changes Aug 7, 2023
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
@alexander-demicev alexander-demicev merged commit 0d69042 into rancher:main Aug 7, 2023
7 checks passed
@alexander-demicev alexander-demicev deleted the devdoc branch August 7, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

4 participants