Refactor e2e suite setup to make it more customizable #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
e2eingressbootstraprefactor
branch
from
6fce68e
to
57a316b
Compare
salasberryfin
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Thanks @alexander-demicev. Looks like a great way of increasing extensibility and making it accessible for end users.
furkatgofurov7
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Part of #603. This PR makes bootstrap cluster setup and ingress deployment more flexible, if anyone imports our framework they can now inject their own way to create bootstrap cluster or deploy ingress on it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: