Install kubectl binary in e2e run suite GH workflow #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
furkatgofurov7
force-pushed
the
set-min-kubectl-version
branch
from
556bf76
to
c496734
Compare
furkatgofurov7
changed the title
alexander-demicev
approved these changes
Aug 16, 2024
yiannistri
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
As an fyi there is another PR in-flight from Danil that bumps the kind/kubectl version to 1.30.4, these should probably be in sync. https://github.com/rancher/turtles/pull/668/files
Danil-Grigorev
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Install kubectl binary with specific version v1.30.0 in e2e run suite GH workflow. e2e nightly runs started failing after #659 where we set MINIMUM_KUBECTL_VERSION to v1.30.0. However, version of kubectl used in GH env (not coming from our codebase) seems to be 1.28.4 which is < v1.30.0 MINIMUM_KUBECTL_VERSION, hence, they started failing https://github.com/rancher/turtles/actions/runs/10419056888/job/28856363769.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Tested this patch here: https://github.com/rancher/turtles/actions/runs/10421045742/job/28862355979
Checklist: