Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in webhook for CC clusters #808

Merged

Conversation

Danil-Grigorev
Copy link
Contributor

What this PR does / why we need it:

A panic occurred during testing ClusterClass usage together with exp. EtcdSnapshot controller running, which may be forgotten later. This is a small fix to address that.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner October 25, 2024 10:31
Copy link

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@furkatgofurov7 furkatgofurov7 enabled auto-merge (squash) October 25, 2024 10:41
@furkatgofurov7 furkatgofurov7 added the kind/bug Something isn't working label Oct 25, 2024
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that!

@furkatgofurov7 furkatgofurov7 merged commit 17fac77 into rancher:main Oct 25, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

Successfully merging this pull request may close these issues.

5 participants