-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support out-of-cluster installation #82
Support out-of-cluster installation #82
Conversation
2fb60d9
to
ec9adf6
Compare
ef8146a
to
57e0a17
Compare
57e0a17
to
bb43298
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is clear to the internal team, it would be nice to have a small document describing what is (out-of/in)-cluster support, the difference between them and why it is needed.
Please disregard if we have a separate issue to document it in rancher-turtles-docs
Same thought as @furkatgofurov7, but additionally we need to have some clear process to pass the kubeconfig to the pod, which could be documented in rancher-turtles-docs + not necessary in the same PR but would prefer to have e2e test coverage here to be sure. |
@furkatgofurov7 @Danil-Grigorev @salasberryfin - i created #94 for us to create an ADR for this. |
Except this, I have nothing major to not merge it |
Thanks for the reviews @richardcase @Danil-Grigorev @furkatgofurov7. I'll be taking on the ADR proposal to have this well documented. |
dc071c0
to
81161b8
Compare
I addressed the latest comments and created a PR for the ADR #95. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks @salasberryfin
We will need to create a documentation issue (in racher-turtles-docs) to cover:
- Handling the RBAC, service account etc
- How to create the secret and mount it
I created rancher/turtles-docs#13 to track this. |
@salasberryfin can we rebase it? |
81161b8
to
340c0e1
Compare
The changes are now up to date after rebase, please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @salasberryfin!
4ef9c9e
to
5c7e2d1
Compare
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
5c7e2d1
to
db01ba9
Compare
What this PR does / why we need it:
This is intended to allow a Rancher operator to choose between deploying rancher-turtles in the same or a different cluster to Rancher Manager. The current implementation of rancher-turtles defaults to an in-cluster configuration with both Rancher Manager and rancher-turtles supposed to be installed together in the same cluster.
The initial idea is to create the client based on whether a flag with a path to a kubeconfig file is passed. When this parameter is used, rancher-turtles will load the REST Config from this file and create a client for an out-of-cluster installation. If it is not, it defaults to the current in-cluster behavior.
Issue #19
Special notes for your reviewer:
Checklist: