Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node and Uninstall RKE2 #98

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Remove node and Uninstall RKE2 #98

wants to merge 5 commits into from

Conversation

dgvigil
Copy link
Contributor

@dgvigil dgvigil commented Nov 9, 2021

What type of PR is this?

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

While this playbook was originally written with the goal of simply bootstrapping a cluster of RKE2, its usage seems to have exceeded that. This change allows for the usage of Ansible to remove nodes from a cluster and uninstalls RKE2 according to RKE2 documentation (https://docs.rke2.io/install/linux_uninstall/).

Which issue(s) this PR fixes:

Fixes #16

This allows for a node to be removed from a cluster and uninstalls RKE2.
@ghost
Copy link

ghost commented Nov 9, 2021

The problem with uninstall script is that needs some fixing before we use it or to locate it. If we specified a diferent tarball_dir (as /opt/rke2) some paths of the script point to /usr/local... See #96 . But if playbook downloads an uninstal script and executes it 'as is', it will fail on /opt/rke2 based deployments.

@dgvigil
Copy link
Contributor Author

dgvigil commented Nov 9, 2021

@gbarceloPIB Agreed. We need to merge in your PR and I will then change the uninstall tasks to use the {{tarball_dir}} location on tarball installs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support cleaning up node data to remove them from cluster
1 participant