✨ Allow relative pathname patterns #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mix test` allows filenames of the form `./test/hello/hello_test.exs`, but `mix test.interactive` did not. While we treat command-line arguments as patterns and not filenames, it's confusing that something that works with `mix test` doesn't work with `mix test.interactive`. We now convert relative pathnames into patterns that will match the list of test files we find in the project. While `mix test` also supports absolute paths and paths outside of the current project, we choose not to do that here. Closes #142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mix testallows filenames of the form./test/hello/hello_test.exs, butmix test.interactivedid not.While we treat command-line arguments as patterns and not filenames, it's confusing that something that works with
mix testdoesn't work withmix test.interactive.We now convert relative pathnames into patterns that will match the list of test files we find in the project.
While
mix testalso supports absolute paths and paths outside of the current project, we choose not to do that here.Closes #142