feat: integrate binance wallet #1329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlert-armin
force-pushed
the
feat/rf-2812-integrate-binance-web3-wallet
branch
2 times, most recently
from
9ca150c to
39d8edb
Compare
arlert-armin
requested review from
Ikari-Shinji-re and
RanGojo
as code owners
arlert-armin
force-pushed
the
feat/rf-2812-integrate-binance-web3-wallet
branch
from
39d8edb to
fd21e8d
Compare
arlert-armin
force-pushed
the
chore/accept-getAccounts-on-evm-connect
branch
from
cc41e86 to
9909e8b
Compare
arlert-armin
force-pushed
the
feat/rf-2812-integrate-binance-web3-wallet
branch
from
fd21e8d to
0089a6a
Compare
nikaaru
reviewed
Dec 8, 2025
Member
nikaaru
left a comment
nikaaru
left a comment
There was a problem hiding this comment.
Thanks,
I left some comments.
arlert-armin
changed the base branch from
chore/accept-getAccounts-on-evm-connect
to
next
arlert-armin
force-pushed
the
feat/rf-2812-integrate-binance-web3-wallet
branch
from
29c2b6f to
6f416d2
Compare
arlert-armin
force-pushed
the
feat/rf-2812-integrate-binance-web3-wallet
branch
2 times, most recently
from
1106ea4 to
201d277
Compare
arlert-armin
force-pushed
the
feat/rf-2812-integrate-binance-web3-wallet
branch
from
8bbbd07 to
34bafa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates Binance Wallet into the Hub and aligns its behavior with the Hub’s EVM namespace and capability model.
Binance Wallet provides broad EVM chain support and behaves correctly across connection, account switching, signing, and network handling. The only notable limitation is the lack of an auto-connect mechanism.
Implementation notes / limitations
Group
EVM
Binance Wallet supports the following EVM chains:
ETHEREUMOPTIMISMLINEAMETISBLASTCELOFANTOMMONADSONICBERACHAINBASEZETA_CHAINARBITRUMBSCSCROLLAVAX_CCHAINAll chains above have been integrated into the Hub’s EVM resolver and connection pipeline.
Feature
❌ Auto Connect
Binance Wallet does not support eager-connect (silent connection).
All other features—connection, account switching, signing, and network handling—work properly with no additional known limitations.
Related PRs
Fixes # (issue)
How did you test this change?
Binance Wallet was tested end-to-end within the Hub environment:
Verified manual connection flow on all supported EVM networks.
Confirmed correct account retrieval and address exposure.
Tested network switching inside Binance Wallet and ensured the Hub updates correctly.
Executed signing operations to validate compatibility.
Test A
Test B
Checklist: