fixed some more affects rules

ranking-agent · Jul 13, 2023 · d34502e · d34502e
1 parent 910e016
commit d34502e
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 4 deletions.
diff --git a/src/rules/Notes b/src/rules/Notes
@@ -9,5 +9,10 @@ The current rules have been created through a somewhat complicated process:
    * remove subclass rules
 5. By hand, I went into kara_typed_rules/rules_with_types_cleaned_finalized.json and changed "biolink:correlated_with"
      to "biolink:positively_correlated_with"
+6. For reasons unclear to me after all this, we still have a bunch of rules of this form:
+    ?e  activity_or_abundance_biolink:affects  ?b  ?e  biolink:similar_to  ?a   => ?a  increased_activity_biolink:affects  ?b
+    For these I go into hand and edit the rule to be
+    ?e  activity_or_abundance_biolink:affects  ?b  ?e  biolink:similar_to  ?a   => ?a  increased_activity_biolink:affects  ?b
+    Changing both the "Rule" and the edge in "template" by adding the correct qualifier
 
 This process is obviously roundabout and we are going to clarify it in the next round of rule minings.
diff --git a/src/rules/kara_typed_rules/check_rule_for_direction.py b/src/rules/kara_typed_rules/check_rule_for_direction.py
diff --git a/src/rules/kara_typed_rules/rules_with_types_cleaned_finalized.json b/src/rules/kara_typed_rules/rules_with_types_cleaned_finalized.json
@@ -4863,7 +4863,7 @@
             }
         },
         {
-            "Rule": "?e  activity_or_abundance_biolink:affects  ?b  ?e  biolink:similar_to  ?a   => ?a  increased_activity_biolink:affects  ?b",
+            "Rule": "?e  increased_activity_or_abundance_biolink:affects  ?b  ?e  biolink:similar_to  ?a   => ?a  increased_activity_biolink:affects  ?b",
             "Head Coverage": "0.000698966",
             "Std Confidence": "0.192307692",
             "PCA Confidence": "0.3125",
@@ -4909,6 +4909,10 @@
                                         {
                                             "qualifier_type_id": "biolink:object_aspect_qualifier",
                                             "qualifier_value": "activity_or_abundance"
+                                        },
+                                        {
+                                            "qualifier_type_id": "biolink:object_direction_qualifier",
+                                            "qualifier_value": "increased"
                                         }
                                     ]
                                 }
@@ -7751,7 +7755,7 @@
             }
         },
         {
-            "Rule": "?e  activity_or_abundance_biolink:affects  ?b  ?e  biolink:similar_to  ?a   => ?a  decreased_activity_biolink:affects  ?b",
+            "Rule": "?e  decreased_activity_or_abundance_biolink:affects  ?b  ?e  biolink:similar_to  ?a   => ?a  decreased_activity_biolink:affects  ?b",
             "Head Coverage": "0.000052801",
             "Std Confidence": "0.104395604",
             "PCA Confidence": "0.154471545",
@@ -7797,6 +7801,10 @@
                                         {
                                             "qualifier_type_id": "biolink:object_aspect_qualifier",
                                             "qualifier_value": "activity_or_abundance"
+                                        },
+                                        {
+                                            "qualifier_type_id": "biolink:object_direction_qualifier",
+                                            "qualifier_value": "decreased"
                                         }
                                     ]
                                 }
@@ -8832,7 +8840,7 @@
             }
         },
         {
-            "Rule": "?e  activity_or_abundance_biolink:affects  ?b  ?e  biolink:similar_to  ?a   => ?a  increased_activity_or_abundance_biolink:affects  ?b",
+            "Rule": "?e  increased_activity_or_abundance_biolink:affects  ?b  ?e  biolink:similar_to  ?a   => ?a  increased_activity_or_abundance_biolink:affects  ?b",
             "Head Coverage": "0.000584971",
             "Std Confidence": "0.192307692",
             "PCA Confidence": "0.3125",
@@ -8878,6 +8886,10 @@
                                         {
                                             "qualifier_type_id": "biolink:object_aspect_qualifier",
                                             "qualifier_value": "activity_or_abundance"
+                                        },
+                                        {
+                                            "qualifier_type_id": "biolink:object_direction_qualifier",
+                                            "qualifier_value": "increased"
                                         }
                                     ]
                                 }
@@ -11779,7 +11791,7 @@
             }
         },
         {
-            "Rule": "?e  activity_or_abundance_biolink:affects  ?b  ?e  biolink:similar_to  ?a   => ?a  decreased_activity_or_abundance_biolink:affects  ?b",
+            "Rule": "?e  decreased_activity_or_abundance_biolink:affects  ?b  ?e  biolink:similar_to  ?a   => ?a  decreased_activity_or_abundance_biolink:affects  ?b",
             "Head Coverage": "0.000051974",
             "Std Confidence": "0.104395604",
             "PCA Confidence": "0.154471545",
@@ -11825,6 +11837,10 @@
                                         {
                                             "qualifier_type_id": "biolink:object_aspect_qualifier",
                                             "qualifier_value": "activity_or_abundance"
+                                        },
+                                        {
+                                            "qualifier_type_id": "biolink:object_direction_qualifier",
+                                            "qualifier_value": "decreased"
                                         }
                                     ]
                                 }