Shadowfax #279
Merged
Shadowfax #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbizon
reviewed
Sep 6, 2024
src/shadowfax.py
Outdated
| else: | ||
| unpinned_node_category = node.get("categories", ["biolink:NamedThing"])[0] | ||
| if len(pinned_node_ids) != 2: | ||
| logger.info(f"{guid}: Pathfinder queries requrie two pinned nodes.") |
cbizon
reviewed
Sep 6, 2024
| logger.info(f"{guid}: Pathfinder queries requrie two pinned nodes.") | ||
| return message, 500 | ||
|
|
||
| async with httpx.AsyncClient(timeout=900) as client: |
There was a problem hiding this comment.
Repeated below, should it be a function?
There was a problem hiding this comment.
That's probably a good idea, yeah.
cbizon
reviewed
Sep 6, 2024
src/shadowfax.py
Outdated
| "predicate": "biolink:related_to", | ||
| "sources": [ | ||
| { | ||
| "resource_id": "infores:shadowfax", |
There was a problem hiding this comment.
Has this been added to infores?
There was a problem hiding this comment.
This was a debugging thing that slipped through the cracks, just to make it easier to differentiate which edges were actually coming from shadowfax. This has been changed to infores:aragorn
cbizon
requested changes
Sep 6, 2024
| main_edge = uuid.uuid1().hex | ||
| before_edge = uuid.uuid1().hex | ||
| after_edge = uuid.uuid1().hex | ||
| knowledge_graph["edges"][main_edge] = { |
There was a problem hiding this comment.
Also needs knowledge level / agent type?
cbizon
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds pathfinder queries into ARAGORN's capabilities. There are still a few things we still want to handle, but this will work for now.
Before merging, we also need to look at how to get the redis working properly.