Support native playback on Windows #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rany2
requested changes
Feb 25, 2025
rany2
requested changes
Feb 25, 2025
|
It did just occur to me that this would be a breaking change - I can flip the default back to preferring |
I wouldn't really consider it a breaking change but I think it's deserving of at least a minor version bump. |
|
At any rate we just need to clear the remaining CI complaints and I'll merge this. Thanks a lot for bearing with me btw |
Signed-off-by: rany <rany2@riseup.net>
Signed-off-by: rany <rany2@riseup.net>
|
any comments before I merge this? |
rany2
approved these changes
Feb 27, 2025
|
Nope, thanks for cleaning it up! |
|
Thanks for putting in the work for this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for playing generated mp3 files on Windows with no external dependencies, just built-in Python standard library functions and native Windows APIs, so users on Windows no longer need to have mpv installed.
One drawback of this method is that isn't possible to stop playback with ctrl-C while the audio is playing. In theory, it should be possible to fix this with an additional dependency (pywin32), although I haven't tried that out yet, and since it's a windows-only library it'd take some fiddling in setuptools, so I opted for the simpler version here. (An even simpler version would be passing the file name to
winsound.PlaySound, but unfortunately that only takes .wav files)