Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored test cases #97

Merged
merged 25 commits into from
Dec 3, 2024
Merged

Refactored test cases #97

merged 25 commits into from
Dec 3, 2024

Conversation

anushka255
Copy link
Collaborator

@anushka255 anushka255 commented Nov 25, 2024

  • Refactored test cases to use .npz files mostly.
  • Consolidated tests/data/input and tests/data/output directories to a single one tests/data.
  • Upgraded numpy to be greater than version 2.0.
  • The docs are failing in this PR because, one of the docs dependency squidpy is not compatible with numpy of version greater than 2.0. Removed squidpy as docs dependency; using scanpy instead #99 deals with this issue.

@anushka255 anushka255 changed the title Aa/refact test Refactored test cases Dec 2, 2024
@anushka255 anushka255 marked this pull request as ready for review December 2, 2024 02:18
@vineetbansal
Copy link
Contributor

vineetbansal commented Dec 2, 2024

If I understand correctly, the tests in this PR are passing with numpy<2 (the pinned workflows) and also numpy>2 (unpinned workflows). Given that this is the case, and we're not explicitly using any features exclusive to numpy 2 and above, why don't we just unpin numpy's version from our requirements completely? We should also update our pinned workflows to whatever latest versions seem to be working on the CI.

@anushka255
Copy link
Collaborator Author

Unpinned everything in pyproject.toml and updated requirements.txt to pin the latest versions of the packages that work.

@vineetbansal vineetbansal merged commit b6a6020 into main Dec 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants