-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOAR-15852] WHOIS Version Bump #2093
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmccann-r7
force-pushed
the
whois_version_bump
branch
from
October 31, 2023 16:14
7bc8bd1
to
966ce95
Compare
cmcnally-r7
force-pushed
the
develop
branch
2 times, most recently
from
November 1, 2023 15:48
5b5cf4a
to
f4f7968
Compare
abmccann-r7
force-pushed
the
whois_version_bump
branch
from
November 3, 2023 13:39
966ce95
to
1df4ffc
Compare
abmccann-r7
force-pushed
the
whois_version_bump
branch
from
November 6, 2023 14:04
1df4ffc
to
0891df3
Compare
cmcnally-r7
approved these changes
Nov 6, 2023
rbowden-r7
approved these changes
Nov 6, 2023
abmccann-r7
added a commit
that referenced
this pull request
Nov 6, 2023
* add empty init file and refresh and plugin.spec updates * unit tests * Domain action unit tests and Address unit tests started * Address action unit tests * Added custom version to requirements.txt * Changed name of unit test * ran black
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
__init__.py
file tounit_test
folder and refreshPR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblerapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num}
andrapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
insight-plugin validate
which callsicon_validate
to linthelp.md
Functional Checklist
tests/
directory created withinsight-plugin samples
tests/$action_bad.json
insight-plugin run -T tests/example.json --debug --jq
insight-plugin run -T all --debug --jq
(use PR format at end)insight-plugin run -R tests/example.json --debug --jq
insight-plugin run --debug --jq
(use PR format at end)Assessment
You must validate your work to reviewers:
insight-plugin validate
and make sure everything passesinsight-plugin run -A
. For single action validation:insight-plugin run tests/{file}.json -A
insight-plugin ... | pbcopy
) and paste the output in a new post on this PR