-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLGN-612] Remove Grr plugin #2130
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaverty-r7
previously approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm but can you rebase it please before merging?
igorski-r7
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase 😄
jerichardson-r7
force-pushed
the
PLGN612-remove-grr
branch
from
November 21, 2023 14:12
f215206
to
652dead
Compare
jerichardson-r7
force-pushed
the
PLGN612-remove-grr
branch
from
November 21, 2023 14:24
652dead
to
689b3c9
Compare
* Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
* added get_sensor action * fixed checksum * sensor stats added acc * finished spec file, regenerated * generated archive sensor action * added example output for archive sensor * refactoring for lint * updated descriptions in spec file for validator * created and tested 2 new actions, need to add unit tests * update spec file * refactored quarantine action, added unit tests for most of the actions * added unit tests 95 percent coverage * fix for plugin validator * fix lint * prospector fix * unit test fix * dympna change * igor updates * lukasz changes * formatting help.md to use 2 spaces instead of 4 * updated version history note
* updated output * updated output for cybereaosn * regen * version bump * specific fake email * fixed schema issue * changing back to rapid7 vendor * version bump in helpmd
* [MC-1452] Update Okta plugin * [MC-1452] Fixed test * [MC-1452] Fix prospector * [MC-1452] Update help.md * [MC-1452] Update SDK image to latest version * [MC-1452] Update unit tests for task --------- Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com>
* [MC-1452] Return status code in Monitor Logs task * [MC-1452] Update exceptions in api.py * [MC-1452] Fix prospector * [MC-1452] Use logger instance
* [MC-1452] Update pagination in Monitor Logs task in Okta plugin * [MC-1452] Update unit tests
* Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com>
* updated status codes + black formatting * regen * added examples to plugin spec * Refresh * removed quotes from variables in spec * tidying up * changed imports to work with github validators * changed task unitest imports to work with github validators * fixed unit tests * Added example outputs to help.md * spec & help changes + status codes fix * checksum * period validation * revert description change * remove full stop in trigger schema
* Updated task cutofftime, removed cleaning of logs, added debug * Updated task cutofftime, removed cleaning of logs, added debug * Removed page index from state if resetting collection time to max lookback * Updated unit tests following task updates --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
* Updated task handling of query interval out of range * Updated unit test following task function update --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
jerichardson-r7
force-pushed
the
PLGN612-remove-grr
branch
from
November 21, 2023 14:56
689b3c9
to
1f2f626
Compare
Need to create it from master branch. New PR for this #2132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Remove Grr plugin as it is now obsolete and not used by customers.
PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblerapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num}
andrapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
insight-plugin validate
which callsicon_validate
to linthelp.md
Functional Checklist
tests/
directory created withinsight-plugin samples
tests/$action_bad.json
insight-plugin run -T tests/example.json --debug --jq
insight-plugin run -T all --debug --jq
(use PR format at end)insight-plugin run -R tests/example.json --debug --jq
insight-plugin run --debug --jq
(use PR format at end)Assessment
You must validate your work to reviewers:
insight-plugin validate
and make sure everything passesinsight-plugin run -A
. For single action validation:insight-plugin run tests/{file}.json -A
insight-plugin ... | pbcopy
) and paste the output in a new post on this PR