Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InsightVM 7.0.0 release #2236

Merged
merged 4 commits into from
Jan 16, 2024
Merged

InsightVM 7.0.0 release #2236

merged 4 commits into from
Jan 16, 2024

Conversation

cmcnally-r7
Copy link
Collaborator

Proposed Changes

Description

Describe the proposed changes:

PR Requirements

Developers, verify you have completed the following items by checking them off:

Testing

Unit Tests

Review our documentation on generating and writing plugin unit tests

  • Unit tests written for any new or updated code

In-Product Tests

If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:

  • Screenshot of job output with the plugin changes
  • Screenshot of the changed connection, actions, or triggers input within the InsightConnect workflow builder

Style

Review the style guide

  • For dependencies, pin OS package and Python package versions
  • For security, set least privileged account with USER nobody in the Dockerfile when possible
  • For size, use the slim SDK images when possible: rapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num} and rapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
  • For error handling, use of PluginException and ConnectionTestException
  • For logging, use self.logger
  • For docs, use changelog style
  • For docs, validate markdown with insight-plugin validate which calls icon_validate to lint help.md

Functional Checklist

  • Work fully completed
  • Functional
    • Any new actions/triggers include JSON test files in the tests/ directory created with insight-plugin samples
    • Tests should all pass unless it's a negative test. Negative tests have a naming convention of tests/$action_bad.json
    • Unsuccessful tests should fail by raising an exception causing the plugin to die and an object should be returned on successful test
    • Add functioning test results to PR, sanitize any output if necessary
      • Single action/trigger insight-plugin run -T tests/example.json --debug --jq
      • All actions/triggers shortcut insight-plugin run -T all --debug --jq (use PR format at end)
    • Add functioning run results to PR, sanitize any output if necessary
      • Single action/trigger insight-plugin run -R tests/example.json --debug --jq
      • All actions/triggers shortcut insight-plugin run --debug --jq (use PR format at end)

Assessment

You must validate your work to reviewers:

  1. Run insight-plugin validate and make sure everything passes
  2. Run the assessment tool: insight-plugin run -A. For single action validation: insight-plugin run tests/{file}.json -A
  3. Copy (insight-plugin ... | pbcopy) and paste the output in a new post on this PR
  4. Add required screenshots from the In-Product Tests section

jerichardson-r7 and others added 4 commits January 16, 2024 15:09
* Updated armorblox plugin with the review comments. (#1721)

* Initial commit for armorblox plugin

* Fix validate errors

* Timestamp changes

* Updated armorblox-sdk 0.1.4 version in requirements.txt

* Updated the suggestions for plugin.spec.yaml

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Updated review comments

* Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py

* Update plugins/armorblox/unit_test/payloads/get_remediation_action.json

* Update plugins/armorblox/unit_test/payloads/get_remediation_action.json

* Updated armorblox plugin with the required fixes

* Updated plugin with latest fixes

* Updated plugin with parameterized on test cases

* "Fixed review comments"

* Updated support field to community in plugin.spec.yaml

---------

Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com>
Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com>

* run black linter, fix unit tests and validators (#1857)

* plgn-618 insight idr update schema (#2164)

* Salesforce - Task Monitor Users: Improved logging (#2170)

* [PLGN-621] Add OAuth to ServiceNow Plugin (#2157)

* Update plugin spec

* Add oauth authentication

* get client id instead of key

* Bump version

* Revert help.md

* Add type annotation for BearerAuth

* Blacken

* Revert Dockerfile

* Fix test

* Add timeout

* black

* Fix unit tests

* Blacken unit tests

* Update request_helper.py

* Updated help.md | Added typehints in unittests

---------

Co-authored-by: igorski-r7 <igor_gorski@rapid7.com>

* [PLGN-408] Insight IDR - Adding new actions for Get Alert Information, Search Alerts, Retrieve Evidence for a Single Alert and Retrieve Actors for a Single Alert (#2175)

* PLGN-408-Adding new actions for Get Alert Information, Search Alerts, Retrieve Evidence for a Single Alert and Retrieve Actors for a Single Alert

* PLGN-408-Adding new actions for Get Alert Information, Search Alerts, Retrieve Evidence for a Single Alert and Retrieve Actors for a Single Alert

* PLGN-408-Adding new actions for Get Alert Information, Search Alerts, Retrieve Evidence for a Single Alert and Retrieve Actors for a Single Alert

* PLGN-408-Re-adding back in size and index to action, dropping version to make a multiple plugin release, adding in type hints

* PLGN-408-Running black format

* PLGN-408-Updating data to be of type object

* PLGN-408-Updating to use f string

* PLGN-408-Removing debug print

* PLGN-408-Updating error var name

* [PLGN-498]- Change Top Remediations id

---------

Co-authored-by: SamhithaTatipalli <57620888+SamhithaTatipalli@users.noreply.github.com>
Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com>
Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com>
Co-authored-by: llaszuk-r7 <99184394+llaszuk-r7@users.noreply.github.com>
Co-authored-by: igorski-r7 <99184344+igorski-r7@users.noreply.github.com>
Co-authored-by: Mike Rinehart <32079048+mrinehart-r7@users.noreply.github.com>
Co-authored-by: igorski-r7 <igor_gorski@rapid7.com>
Co-authored-by: rbowden-r7 <144030336+rbowden-r7@users.noreply.github.com>
* Spec file mapped

* Update version

* Latest code change

* Update version to 7

* Fix help.md

* Validator fixes

* Update IP in helpmd

* Fix inconsistency

* Fix inconsistency

* Add connection version

* Update query

* Remove connection version

* Updated query

* Updated comments

* Black formatting

* change func call to util

* Fix scan id input again

* Remove filter function, made it local

* Remove filter function, made it local

* Fix silly mistakes

* Change f string to multiline

* Handle key error

* Add asset group id in query

* Add asset group id in query

* Linter
* Add in forgotten ip address and hostname

* Updated query with source hardcoded

* nosec on query & move strip msft to nexpose id

* New query - removed duplicates

* Reinsert scan ID

* Remove strip msft

* Fix plugin validators

* Add connection version:

* Fix typo in solution id and category

* Remove all inputs minus site id & new query & new output mapping

* Remove all inputs minus site id & new query & new output mapping

* Remove all inputs minus site id & new query & new output mapping

* Update help.md

* Scan id added into report payload

* Update connection version

* Remove unused fstring

* Fix helpmd breaking validator

* Add scan id to output

* Add scan ID to output in trigger

* Update spacing in query

* Linter

* Update descriptions
* Return version back to 7.0.0

* Return connection version to 7

* Update changelog
@cmcnally-r7 cmcnally-r7 merged commit 4d02599 into master Jan 16, 2024
11 of 12 checks passed
@cmcnally-r7 cmcnally-r7 deleted the ivm_7.0.0-release branch January 17, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants