Palo alto cortex xdr 4.0.3 release #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add custom config exceptions and update unit tests for errors * Fix bug in get incidents trigger, update version * Update checksum for task schema * Util update, no unit tests for testing * Broken unit test fix 2 * Fix unit tests
…igger (#2903) * Undo change to list split for get incidents trigger * Black formatting * Remove self.maxdiff in unit test * Update spec file
igorski-r7
approved these changes
Oct 28, 2024
ekelly-r7
reviewed
Oct 28, 2024
| @@ -33,7 +33,7 @@ def run(self, params={}): | |||
| ) | |||
| # Separate the host identifier values | |||
| for incident in incidents: | |||
| incident["hosts"] = Util.split_list_values(incident.get("hosts", []), ":") | |||
| incident["hosts"] = Util.split_list_values(incident.get("hosts", [])) | |||
There was a problem hiding this comment.
Does this change also need undone or is it ok to leave in the release?
There was a problem hiding this comment.
It's okay, I kept it in since its not consequential and has the same functionality, it's just one less manual input for that helper method
ekelly-r7
reviewed
Oct 28, 2024
| @@ -27,9 +27,11 @@ def split_list_values(input_list: list, separator: str) -> list: | |||
| output_list = [] | |||
| for item in input_list: | |||
| if isinstance(item, str): | |||
| item_split = item.split(separator) | |||
| item_split = item.split(":") | |||
There was a problem hiding this comment.
Should this also be undone if we aren't making changes to the triggers?
ekelly-r7
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobodyin theDockerfilewhen possiblerapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num}andrapid7/insightconnect-python-3-38-plugin:{sdk-version-num}insight-plugin validatewhich callsicon_validateto linthelp.mdFunctional Checklist
tests/directory created withinsight-plugin samplestests/$action_bad.jsoninsight-plugin run -T tests/example.json --debug --jqinsight-plugin run -T all --debug --jq(use PR format at end)insight-plugin run -R tests/example.json --debug --jqinsight-plugin run --debug --jq(use PR format at end)Assessment
You must validate your work to reviewers:
insight-plugin validateand make sure everything passesinsight-plugin run -A. For single action validation:insight-plugin run tests/{file}.json -Ainsight-plugin ... | pbcopy) and paste the output in a new post on this PR