[SOAR-18367] Updating Get Agent Details action (SI) #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmurray-r7
force-pushed
the
soar_18367_agent
branch
from
fe74020 to
0b4a6fa
Compare
rmurray-r7
requested review from
cmcnally-r7,
igorski-r7,
dlaverty-r7,
joneill-r7,
rbowden-r7 and
ekelly-r7
rbowden-r7
approved these changes
Dec 6, 2024
ekelly-r7
approved these changes
Dec 6, 2024
rmurray-r7
added a commit
that referenced
this pull request
Dec 6, 2024
* Updating Get Agent Details action * black
rmurray-r7
added a commit
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Regarding an issue the customer has experienced, when executing the action (
get_agent_details) and no data is returned, a Plugin Exception is raised (when it shouldn't be as the action technically ran successfully) instead of returning an empty dictionary. This failure interrupts customers workflows (and returning an empty dictionary is also used in the majority of other actions).Describe the proposed changes:
get_agent_detailsaction to allow for an empty result to be returnedTesting
Unit Tests
Update the unit test to reflect action change:
