Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run spark-rapids-jni CI #17781

Merged
merged 21 commits into from
Feb 4, 2025
Merged

Run spark-rapids-jni CI #17781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
65ad815
Run spark-rapids-jni CI
KyleFromNVIDIA Jan 22, 2025
e6a044c
Oops
KyleFromNVIDIA Jan 22, 2025
0ec1b10
Container
KyleFromNVIDIA Jan 22, 2025
1e5c19f
Diff
KyleFromNVIDIA Jan 22, 2025
bf0c0da
Use temporary image from Spark team
KyleFromNVIDIA Jan 23, 2025
e122f1c
Debug
KyleFromNVIDIA Jan 23, 2025
36c0d39
More debugging
KyleFromNVIDIA Jan 23, 2025
500f43f
More listing
KyleFromNVIDIA Jan 23, 2025
d0c755d
Safe
KyleFromNVIDIA Jan 23, 2025
cd23566
Build
KyleFromNVIDIA Jan 23, 2025
040600f
mkdir
KyleFromNVIDIA Jan 23, 2025
8390b00
Set name
KyleFromNVIDIA Jan 23, 2025
6625931
Deliberately introduce build error for spark-rapids-jni
KyleFromNVIDIA Jan 23, 2025
95d63fd
Revert "Deliberately introduce build error for spark-rapids-jni"
KyleFromNVIDIA Jan 23, 2025
01ca64e
Use official spark-rapids-jni CI image
KyleFromNVIDIA Jan 30, 2025
d263f97
Review feedback
KyleFromNVIDIA Jan 30, 2025
bd31192
Add test_spark condition
KyleFromNVIDIA Jan 30, 2025
4c63457
Re-run CI
KyleFromNVIDIA Jan 31, 2025
0fda1df
Merge branch 'branch-25.02' into run-spark-ci
KyleFromNVIDIA Jan 31, 2025
f8570b1
Merge branch 'branch-25.04' into run-spark-ci
KyleFromNVIDIA Jan 31, 2025
f8d97b5
Use test_java
KyleFromNVIDIA Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ jobs:
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@branch-25.04
with:
enable_check_generated_files: false
ignored_pr_jobs: "telemetry-summarize"
ignored_pr_jobs: "telemetry-summarize spark-rapids-jni"
conda-cpp-build:
needs: checks
secrets: inherit
Expand Down Expand Up @@ -342,6 +342,10 @@ jobs:
node_type: "cpu4"
build_type: pull-request
run_script: "ci/cudf_pandas_scripts/pandas-tests/diff.sh"
spark-rapids-jni:
needs: changed-files
uses: ./.github/workflows/spark-rapids-jni.yaml
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_java

telemetry-summarize:
# This job must use a self-hosted runner to record telemetry traces.
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/spark-rapids-jni.yaml
View file
Open in desktop
KyleFromNVIDIA marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: spark-rapids-jni

on:
workflow_call:

jobs:
spark-rapids-jni-build:
runs-on: linux-amd64-cpu8
container:
image: rapidsai/ci-spark-rapids-jni:rockylinux8-cuda12.2.0
KyleFromNVIDIA marked this conversation as resolved.
Show resolved Hide resolved
steps:
- uses: actions/checkout@v4
with:
repository: NVIDIA/spark-rapids-jni
submodules: recursive
- uses: actions/checkout@v4
with:
path: thirdparty/cudf
- name: "Build spark-rapids-jni"
run: |
mkdir target
GPU_ARCHS=90 LIBCUDF_DEPENDENCY_MODE=latest USE_GDS=on scl enable gcc-toolset-11 build/buildcpp.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already looks great.

We can improve it by actually executing the exact command with Maven build a regular spark-rapids-jni build would

./build/build-in-docker verify -DskipTests -DGPU_ARCHS=90 -Dlibcudf.dependency.mode=latest

It can be a follow-up change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that work when it's already inside a Docker container though?

Copy link
Contributor

@gerashegalov gerashegalov Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may work but good point that it is not desired to recurse into a nested container. What I mean is the Maven command following run-in-docker https://github.com/NVIDIA/spark-rapids-jni/blob/6883364a87dec972ce9e51027e716eba860af568/build/build-in-docker#L45C1-L50

We can change the script such that the run-in-docker part is skip-able.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll do that in a follow-up PR.