Remove cudf.Scalar from .dt timedelta properties #17863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
Matt711
reviewed
Jan 30, 2025
| @@ -484,88 +484,57 @@ def components(self) -> dict[str, ColumnBase]: | |||
| 4 37 13 12 14 234 0 0 | |||
| """ | |||
|
|
|||
| @functools.cache | |||
| def get_unit_conversion(reso: str) -> np.timedelta64: | |||
There was a problem hiding this comment.
It seems like we can reuse this function throughout this module.
There was a problem hiding this comment.
Good idea. Was able to move this to the top level of this file
Matt711
approved these changes
Jan 31, 2025
Sure thing. This PR isn't a priority so don't want to consume merge CI time |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Towards #17843
Checklist